The description is: " Use when printing basket groups. " The list of possible templates should be precised. M. Saby
There are only 3 valid values for OrderPdfFormat : pdfformat::layout2pages pdfformat::layout3pages in french:pdfformat::layout3pagesfr We should improve syspref description, and the manual. M. Saby
Created attachment 24735 [details] [review] Bug 11459: Make OrderPdfFormat syspref description more verbose This patch adds precisions to OrderPdfFormat syspref. To test: in staff interface, check the syspref is now presented that way: Use ___ layout when printing basket groups (in the form pdfformat::layoutname). Two english layouts are available: pdfformat::layout2pages and pdfformat::layout3pages ; one french layout is available: pdfformat::layout3pagesfr. M. Saby
Created attachment 24787 [details] [review] [PATCH] Bug 11459: Make OrderPdfFormat syspref description more verbose
Created attachment 25351 [details] [review] Bug 11459: Make OrderPdfFormat syspref description more verbose This patch adds precisions to OrderPdfFormat syspref. To test: in staff interface, check the syspref is now presented that way: Use ___ layout when printing basket groups (in the form pdfformat::layoutname). Two english layouts are available: pdfformat::layout2pages and pdfformat::layout3pages ; one french layout is available: pdfformat::layout3pagesfr. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 25569 [details] [review] [PASSED QA] Bug 11459: Make OrderPdfFormat syspref description more verbose This patch adds precisions to OrderPdfFormat syspref. To test: in staff interface, check the syspref is now presented that way: Use ___ layout when printing basket groups (in the form pdfformat::layoutname). Two english layouts are available: pdfformat::layout2pages and pdfformat::layout3pages ; one french layout is available: pdfformat::layout3pagesfr. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed English/French.
Created attachment 25670 [details] [review] [COUNTER PATCH] Bug 11459: use drop-down to set OrderPdfFormat syspref This patch converts the OrderPdfFormat to a choice. To test: [1] Look at OrderPdfFormat in the system preferences editor. Verify that there is a drop-down giving a choice among the three PDF basketgroup printing formats. [2] Change the OrderPdfFormat setting and print a basketgroup. Verify that the chosen template is used. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
The system preferences editor lets one specify a set of choice for a syspref. A drop-down makes more sense than asking the user to copy and paste their chosen value from the system preference, and also makes it less error-prone. Consequently, I've attached a counter-patch.
11828 will introduce a German translation. IHO, Mathieus patch would be more flexible for new translations. Marc
(In reply to Marc Véron from comment #8) > 11828 will introduce a German translation. > > IHO, Mathieus patch would be more flexible for new translations. Can you say why you think that? In both cases, the list of options is subject to exactly the same translation tools, but my patch makes the display both more concise and less likely for a user to make an error that would break basketgroup printing.
I agree that the drop down list would be more user friendly. What I wanted to say is that without the drop down list it would be easier to add other templates by just adding the files. And imagine that each and every of the Koha languages would have it's own template(s). That would give a very long drop down list. BTW I tested an non-existing template (pdfformat::layout2pagesxx). It simply leads to an error message while printing: "Invalid PDF Format set - Please go to the systempreferences and set a valid pdfformat"
Adding the files is not enough - for security reasons the valid pdf formats are currently hardcoded into basketgroup.pl. So touching the code is always needed in some way to add another template currently.
(In reply to Marc Véron from comment #10) > I agree that the drop down list would be more user friendly. OK > What I wanted to say is that without the drop down list it would be easier > to add other templates by just adding the files. Katrin has addressed this point. > And imagine that each and every of the Koha languages would have it's own > template(s). That would give a very long drop down list. I am very dubious whether that is a real possibility, considering that it's been more more than four years since the feature was originally introduced, and only now is somebody adding support for a third language. In fact, I really hope that we have a better templating system in place long before somebody contemplates adding a fourth language, as requiring a user to change Perl code and binary files to customize their printed purchase orders is, to put it mildly, less than ideal. > BTW I tested an non-existing template (pdfformat::layout2pagesxx). It simply > leads to an error message while printing: "Invalid PDF Format set - Please > go to the systempreferences and set a valid pdfformat" That still counts as broken. Better to constrain the user to options that are guaranteed to work.
I was not aware of the hard coding in basketgroup.pl So let's go ahead - Sign off follows.
Hello I wrote something for allowing customized basketgroup. It failed: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 By the way, the current system (using perl for the pdf, and not a html template) is a nightmare. This bug was only to make the description of the syspref a bit more understandable for the average librarian ;-) Mathieu
(in my library we made our own template - this was before a french template was available - so, we had to write a local patch for allowing koha to use a non-standard template) Mathieu
Created attachment 25713 [details] [review] [Signed-off] Bug 11459: use drop-down to set OrderPdfFormat syspref This patch converts the OrderPdfFormat to a choice. To test: [1] Look at OrderPdfFormat in the system preferences editor. Verify that there is a drop-down giving a choice among the three PDF basketgroup printing formats. [2] Change the OrderPdfFormat setting and print a basketgroup. Verify that the chosen template is used. Signed-off-by: Galen Charlton <gmc@esilibrary.com> I followed the test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Sounds like we have an agreement, so I'm setting this to signed-off.
Thanks, Galen. I did not set it to "Signed off" because it was "In Discussion". Marc
Created attachment 26205 [details] [review] [PASSED QA] Bug 11459: use drop-down to set OrderPdfFormat syspref This patch converts the OrderPdfFormat to a choice. To test: [1] Look at OrderPdfFormat in the system preferences editor. Verify that there is a drop-down giving a choice among the three PDF basketgroup printing formats. [2] Change the OrderPdfFormat setting and print a basketgroup. Verify that the chosen template is used. Signed-off-by: Galen Charlton <gmc@esilibrary.com> I followed the test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves usability of the OrderPdfFormat system preference. Works as described, only changes YAML file.
Pushed to master.
This change is quite confusing if you have a customized pdf, the selected value is the first one of the dropdown list. Which is different from the value in the DB.
I should have read the discussion before raising something already discussed.
Pushed to 3.14.x, will be in 3.14.08
Pushed to 3.12.x will be in 3.12.13