Bug 11475 - Batch modification process ends with broken link
Summary: Batch modification process ends with broken link
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 9044
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-03 14:58 UTC by Owen Leonard
Modified: 2015-06-04 23:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11475: Links are broken when editing/deleting items in batch (3.97 KB, patch)
2014-01-07 14:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11475: Links are broken when editing/deleting items in batch (4.03 KB, patch)
2014-01-08 20:34 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 11475: Links are broken when editing/deleting items in batch (4.11 KB, patch)
2014-01-10 13:46 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-01-03 14:58:58 UTC
As reported on the koha-devel list:

---

1- First we search for records with multiple items (books or serials, does not matter)

2- We open this record we found with multiple items for editing

3- We chose "Edit items in batch" option from the "Edit" menu

4- We make corrections on the fields under the "Edit item"  (For example we change the collection code as "fiction")

5- We save this using "Save button" at the bottom, after we are done.

6- Just after we save, there will be a button named "Done" available just under the page, and when we click on "Done" we encounter the Error screen.

---

The "Done" link points to /cgi-bin/koha/tools/CATALOGUING
Comment 1 Jonathan Druart 2014-01-07 14:18:29 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2014-01-08 20:34:45 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-01-10 13:46:09 UTC
Created attachment 24128 [details] [review]
Bug 11475: Links are broken when editing/deleting items in batch

Bug introduced by bug 9044.

Test plan:
1- First we search for records with multiple items (books or serials,
does not matter)
2- We open this record we found with multiple items for editing
3- We chose "Edit items in batch" option from the "Edit" menu
4- We make corrections on the fields under the "Edit item"  (For example
we change the collection code as "fiction")
5- We save this using "Save button" at the bottom, after we are done.
6- Just after we save, there will be a button named "Done" available
just under the page, and when we click on "Done" we encounter the Error
screen.

Before the patch, the "Done" link points to
/cgi-bin/koha/tools/CATALOGUING.
After applying the patch, the "Done" link points to the biblio detail
page.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, works as advertised
Comment 4 Galen Charlton 2014-01-10 16:12:53 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Fridolin Somers 2014-02-18 09:07:51 UTC
Patch pushed to 3.14.x, will be in 3.14.4.