Currently, borrowernumber is shown without any other information in the logs. One of our libraries has pointed out that it would be much more useful if they saw the firstname/lastname of the librarian performing tasks and the users connected to those tasks. Seems reasonable to me.
Created attachment 23919 [details] [review] Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available)
Created attachment 23926 [details] [review] Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 24214 [details] [review] [PASSED QA] Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script.
Pushed to master, along with a patch that makes a cosmetic improvement to the display of user/patron names and IDs. Thanks, David!