Bug 11477 - Add names for librarian and borrowers in the logs
Summary: Add names for librarian and borrowers in the logs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Transaction logs (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on: 11473
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-06 01:08 UTC by David Cook
Modified: 2014-12-07 20:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11477 - Add names for librarian and borrowers in the logs (4.61 KB, patch)
2014-01-06 04:23 UTC, David Cook
Details | Diff | Splinter Review
Bug 11477 - Add names for librarian and borrowers in the logs (4.67 KB, patch)
2014-01-06 08:43 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11477 - Add names for librarian and borrowers in the logs (4.79 KB, patch)
2014-01-12 21:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2014-01-06 01:08:37 UTC
Currently, borrowernumber is shown without any other information in the logs.

One of our libraries has pointed out that it would be much more useful if they saw the firstname/lastname of the librarian performing tasks and the users connected to those tasks.

Seems reasonable to me.
Comment 1 David Cook 2014-01-06 04:23:00 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-01-06 08:43:23 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-01-12 21:24:46 UTC
Created attachment 24214 [details] [review]
[PASSED QA] Bug 11477 - Add names for librarian and borrowers in the logs

This patch adds the first name and surname of the librarian and the
user involved in a transaction log, if available.

If neither the firstname or the surname is available, then the 'object'
number will be prefaced with the 'Member' qualifier.

_TEST PLAN_

0) This patch depends on Bug 11473, so you must apply it first

Before applying this patch (11477):
1) View the logs.
2) Note that the Librarian column just has a number
3) Note that the Object column will just say Member X (where X is a
number), in the circulation, fines, and patron/member modules.

Apply the patch.

4) Reload the logs (you don't need to make new ones)
5) Note that the Librarian and Object columns mentioned above now
have firstname and surname appearing (where available)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.
Comment 4 Galen Charlton 2014-01-17 06:08:19 UTC
Pushed to master, along with a patch that makes a cosmetic improvement to the display of user/patron names and IDs.

Thanks, David!