Bug 11493 - Batch Item Modification not handling unicode characters
Summary: Batch Item Modification not handling unicode characters
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-08 02:45 UTC by Karam Qubsi
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters" (1.33 KB, patch)
2014-03-05 12:48 UTC, Jonathan Druart 		Details | Diff | Splinter Review
[Signed-off] Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters" (1.41 KB, patch)
2014-03-06 14:15 UTC, Marc Véron 		Details | Diff | Splinter Review
[PASSED QA] Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters" (1.55 KB, patch)
2014-03-12 09:55 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karam Qubsi 2014-01-08 02:45:13 UTC 
Hi,
Today while trying to make a batch modification for 10 items related to one bib record , we entered an Arabic characters (ق ك و )
 in the -o subfield and we get bad results :Ù Ù Ù

you can try this by open a bib record with more than 1 item ,
select all items
chose Modify selected items

try to enter some Arabic character in any  sub-field like in (x - Non-public note) you can put any letters from the Arabic alphabetic ( أ ب ت ث ج ح ...) 

save . and you will see the results .
Comment 1 Jonathan Druart 2014-03-05 12:48:22 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-03-06 14:15:38 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-12 09:55:47 UTC 
Created attachment 26149 [details] [review]
[PASSED QA] Bug 11493: Revert "Bug 6869 Batch item modification fails whit accented characters"

This reverts commit c9905750e53e2e1615842ac696d5eeb0a8ac07fc.

Test plan:
1/ Open a bib record with more than 1 item ,
2/ Select all items
3/ Chose Modify selected items
4/ put you "ق ك و" in notes
5/ Verify the items have been updated correctly
6/ put you "éàç" in notes
7/ Verify the items have been updated correctly
8/ put you "ق ك و éàç" in notes
9/ Verify the items have been updated correctly

Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed bug on master and that the patch fixes it.
Passes all tests and the QA script.
Comment 4 Galen Charlton 2014-03-12 18:03:45 UTC 
Pushed to master.  Thanks, Jonathan!
Comment 5 Fridolin Somers 2014-05-16 08:11:37 UTC 
Pushed to 3.14.x, will be in 3.14.07
Comment 6 Kyle M Hall (khall) 2014-06-06 13:49:28 UTC 
Pushed to 3.12.x will be in 3.12.13