Bug 1153 - opac-userupdate.pl update to allow moderation, and templatize
Summary: opac-userupdate.pl update to allow moderation, and templatize
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P2 minor (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-17 01:47 UTC by Owen Leonard
Modified: 2013-12-05 22:36 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Moving the contents of an error message from the script to the template (2.18 KB, patch)
2009-07-06 14:08 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-20 23:39:28 UTC


---- Reported by oleonard@myacpl.org 2006-08-17 01:47:20 ----

opac-userupdate.pl allows members to submit corrections of their user details to the administrator. The script contains hard-coded text of the email which the administrator will receive. This should be templated or parameterized for internationalization.



---- Additional Comments From oleonard@myacpl.org 2007-08-13 12:16:14 ----

Still a bug in rel_3_0



---- Additional Comments From jmf@liblime.com 2007-10-04 14:14:54 ----

bumping up to 3.0



---- Additional Comments From joe.atzberger@liblime.com 2008-01-10 11:07:50 ----

opac-userupdate has other serious issues.  The email sent doesn't catch all the data supplied by the user.  For example, I added a "work/fax" number in the form, but the email doesn't catch it as either Pro or Fax.  It duplicates some field data, and then doesn't in other fields.  I have doubts about this process anyway, relying on manual re-entry after email receipt by the sysadmin...  Weird.  

Anyway, here's the email output:

Borrower jmf

has requested to change her/his personal details.
Please check these new details and make the changes:
title :   -->
surname : Ferraro  -->  Ferraro
firstname : Josh  -->  Josh
phone : 1 740 707 7654  -->  1 740 707 7654
fax :   -->
streetaddress :   -->  449 E. State St.
emailaddress :   -->  jmf@liblime.com
city : Athens  -->  Athens
phonepro :   -->


Thanks,
Koha



---- Additional Comments From jmf@liblime.com 2008-03-17 16:31:46 ----

Changing the title on this one, re-assigning to myself for now, 



---- Additional Comments From jmf@liblime.com 2008-03-17 16:51:54 ----

*** http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1597 has been marked as a duplicate of this bug. ***



---- Additional Comments From oleonard@myacpl.org 2009-07-06 14:08:03 ----

Created an attachment
Moving the contents of an error message from the script to the template





---- Additional Comments From gmcharlt@gmail.com 2009-07-13 03:57:54 ----

Pushed Owen's patch fixing the translatiblity of the error message.



---- Additional Comments From gcollum@gmail.com 2009-08-12 00:53:57 ----

Submitted bug for http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2505 for enabling warnings in perl modules that took care of a couple of more issues with opac-updateuser.pl.

It removes duplicate fields, and cleans up some of the variables.  The date system preference is used for the birthdate in the resulting email.  The B_address field, combination of two variables, now shows up in the email.  And as an added bonus the field names for the data that the patron changed appear as uppercase in the email.

All of the fields seem to work now, except for the select boxes for "Items Borrowed Notification" and "Items Returned Notification."




--- Bug imported by chris@bigballofwax.co.nz 2010-05-20 23:39 UTC  ---

This bug was previously known as _bug_ 1153 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1153
Imported an attachment (id=76)

Actual time not defined. Setting to 0.0
The original submitter of attachment 76 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Kyle M Hall 2012-02-08 13:28:55 UTC
I'm wondering if, instead of an automated email, there should be a better system for updating borrower information. I would create a table to store the requested data, then have a system where by the librarian can go through each borrower record, see the changes requested as compared to the original data, then give the changes a thumbs up or thumbs down. Perhaps the borrower could receive an email confirming or denying the change request ( with an optional reason, perhaps ).
Comment 2 Owen Leonard 2012-02-08 13:36:58 UTC
I think we have a great opportunity to integrate and update to this system with a system for online patron registration: Both could potentially use the same table to store information which would require the librarian to validate and approve.
Comment 3 Kyle M Hall 2012-02-08 14:53:37 UTC
That sounds like an excellent idea. We could even have printable temporary library cards! One issue: my library system requires a piece of mail to verify a home address. What do other libraries require? Should it include the ability to submit scanned documents, or should just let you fill out your data, bring your documents in and let a librarian verify and complete the process.

(In reply to comment #2)
> I think we have a great opportunity to integrate and update to this system with
> a system for online patron registration: Both could potentially use the same
> table to store information which would require the librarian to validate and
> approve.
Comment 4 Owen Leonard 2012-02-08 16:48:38 UTC
Taking this discussion to Bug 7067
Comment 5 Katrin Fischer 2013-04-13 21:30:30 UTC
Has this been fixed by the new patron self registration feature?
Comment 6 Nicole C. Engard 2013-04-16 14:28:39 UTC
I think it has.