Bug 11601 - Bootstrap theme has CSS files that do not have LESS counterparts
Summary: Bootstrap theme has CSS files that do not have LESS counterparts
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Liz Rea
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11411 11896
  Show dependency treegraph
 
Reported: 2014-01-22 19:51 UTC by Liz Rea
Modified: 2020-01-06 20:14 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11601 - creating parity between less and css folders, minifying CSS (206.25 KB, patch)
2014-01-22 21:38 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 11601 - creating parity between less and css folders, minifying CSS (205.04 KB, patch)
2014-02-04 21:55 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 11601 - creating parity between less and css folders, minifying CSS (183.43 KB, patch)
2014-03-04 23:04 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 11601 - creating parity between less and css folders, minifying CSS (291.00 KB, patch)
2014-03-05 20:51 UTC, Liz Rea
Details | Diff | Splinter Review
[Signed-off] Bug 11601 - creating parity between less and css folders, minifying CSS (291.17 KB, patch)
2014-03-06 05:43 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2014-01-22 19:51:34 UTC
We should create parity between the LESS and CSS folders in the Bootstrap theme. CSS should be minified to discourage hand editing.

Steps to this available at http://www.lesscss.org/#usage 

Note that you will need to install Node.js first: http://nodejs.org/

A convenient tool for development with less: https://github.com/jonycheung/Dead-Simple-LESS-Watch-Compiler

We should probably also start a wiki page to point people to on how to modify core less files in the bootstrap theme.
Comment 1 Liz Rea 2014-01-22 21:38:56 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-01-30 17:08:44 UTC
Everything looks good except one file: This patch adds "jquery.css," which seems to be a renamed version of jquery.rating.css. Was this an error from the Less compile process?
Comment 3 Liz Rea 2014-01-30 20:13:01 UTC
hmm possibly, I'll have a check. 

Liz
Comment 4 Liz Rea 2014-02-04 21:55:22 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2014-03-04 15:50:35 UTC
Wanted to test, patch does not apply.
Comment 6 Liz Rea 2014-03-04 22:53:26 UTC
Owen,

No, I looked in master and that jquery file is there in the css for bootstrap, but not in the less, and it's called jquery.css. If it's not supposed to be there, I'll happily remove it.

However, the newest attached patch left it alone.

Liz
Comment 7 Liz Rea 2014-03-04 23:04:29 UTC Comment hidden (obsolete)
Comment 8 Marc Véron 2014-03-05 09:44:27 UTC
To test:
Verify the bootstrap theme still works as it should.
-- MV: OK

In the bootstrap theme files:
verify that all CSS files have a counterpart in the less directory
-- MV:OK

verify that all CSS files have been minified

--MV: Not minified files found in koha-tmpl/opac-tmpl/bootstrap/css
datatable.css
opac.css
opac-old.css
Comment 9 Liz Rea 2014-03-05 20:51:59 UTC Comment hidden (obsolete)
Comment 10 Marc Véron 2014-03-06 05:43:06 UTC Comment hidden (obsolete)
Comment 11 Jonathan Druart 2014-03-19 16:32:31 UTC
It seems that mixings.css and sco-old.css are not used.
Maybe should we remove them too?

Owen, could you confirm that?
Comment 12 Owen Leonard 2014-04-03 14:50:33 UTC
> It seems that mixings.css and sco-old.css are not used.
> Maybe should we remove them too?

opac-old.css and sco-old.css are unwanted byproducts of my development process and should not have been committed. They should be removed.

responsive.css and mixins.css are byproducts of the automatic LESS build process and should not be added (they are currently not in git).
Comment 13 Liz Rea 2019-02-07 17:16:28 UTC
I think this one is long fixed now.