Bug 11736 - Use new DataTables include in Koha news templates
Summary: Use new DataTables include in Koha news templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/koha-news.pl
Keywords:
Depends on:
Blocks: 11720
  Show dependency treegraph
 
Reported: 2014-02-10 19:13 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11736 - Use new DataTables include in Koha news templates (4.54 KB, patch)
2014-02-10 19:21 UTC, Owen Leonard
Details | Diff | Splinter Review
SIGNED-OFF-Bug-11736-Use-new-DataTables-include-in-Koha-news-tmpl (4.57 KB, patch)
2014-02-24 16:51 UTC, wajasu
Details | Diff | Splinter Review
[PASSED QA] Bug 11736 - Use new DataTables include in Koha news templates (4.69 KB, patch)
2014-02-25 07:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-10 19:13:32 UTC
Koha news template should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-10 19:21:43 UTC Comment hidden (obsolete)
Comment 2 wajasu 2014-02-24 16:51:13 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-25 07:25:25 UTC
Created attachment 25605 [details] [review]
[PASSED QA] Bug 11736 - Use new DataTables include in Koha news templates

Bug 10649 introduced a new include file for adding DataTables-related
JavaScript assets. This patch adds use of this include file to the Koha
news page.

To test you should have existing news items with varying creation and
expiration dates. Apply the patch and confirm that table sorting works
correctly for all settings of the dateformat system preference.

C4::NewsChannels.pm has been modified so that it now passes an
unformatted date to the template, where the KohaDates plugin is used to
apply the correct formatting. Sorting is based on the unformatted date.

Also corrected: Capitalization errors.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Also passes tests and QA script.
Comment 4 Galen Charlton 2014-02-27 16:09:21 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-21 10:14:49 UTC
Pushed to 3.14.x, will be in 3.14.07