Koha news template should be updated to use the new DataTables include file introduced by Bug 10649.
Created attachment 25181 [details] [review] Bug 11736 - Use new DataTables include in Koha news templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Koha news page. To test you should have existing news items with varying creation and expiration dates. Apply the patch and confirm that table sorting works correctly for all settings of the dateformat system preference. C4::NewsChannels.pm has been modified so that it now passes an unformatted date to the template, where the KohaDates plugin is used to apply the correct formatting. Sorting is based on the unformatted date. Also corrected: Capitalization errors.
Created attachment 25591 [details] [review] SIGNED-OFF-Bug-11736-Use-new-DataTables-include-in-Koha-news-tmpl sortable date columns appeared and behaved just fine.
Created attachment 25605 [details] [review] [PASSED QA] Bug 11736 - Use new DataTables include in Koha news templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the Koha news page. To test you should have existing news items with varying creation and expiration dates. Apply the patch and confirm that table sorting works correctly for all settings of the dateformat system preference. C4::NewsChannels.pm has been modified so that it now passes an unformatted date to the template, where the KohaDates plugin is used to apply the correct formatting. Sorting is based on the unformatted date. Also corrected: Capitalization errors. Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Also passes tests and QA script.
Pushed to master. Thanks, Owen!
Pushed to 3.14.x, will be in 3.14.07