For the sake of consistency with things like road types and (eventually) ethnicity, the BorrowersTitles system preference should be converted to an authorized value type.
Created attachment 94637 [details] [review] Bug 11815: Convert BorrowersTitles to an authorised value This patch removes the BorrowersTitles system preference in favor of using authorized values to store patron titles. To test, apply the patch and run the database update. - In Administration -> Authorized values, locate the category 'PATRON_TITLE'. - Create two or more authorized values with new patron titles. - In Administration -> System preferences -> Patrons, there should be no entry for BorrowersTitles. - Create or edit a patron. Under "Salutation" your authorized values should appear correctly. - Log in to the OPAC and go to "Your personal details." Confirm that the correct values are shown there. - Remove all PATRON_TITLE authorized values and confirm that the "Salutation" field no longer appears on the staff client or OPAC patron entry form.
Hi Owen, Everything work as described, I only have a question about the last point. After deleting all the valued in PATRON_TITLE, "Salutations" fields are correctly hidden on both OPAC and staff client, but until I modify the patron, the salutation I first saved is still displayed on different pages and breadcrumbs, for example : - /koha/circ/circulation.pl? - /koha/members/moremember.pl? - /koha/opac-main.pl - /koha/opac-user.pl - /koha/opac-memberentry.pl Is the 'borrowers.title' sql field supposed to be cleaned after deleting the linked value, or does the patch behaves as you excepted and so I just have to sign it ? Thank you !
(In reply to Séverine Queune from comment #2) > Is the 'borrowers.title' sql field supposed to be cleaned after deleting the > linked value The field is NOT expected to be cleared when the authorized value is removed. This is consistent with the current behavior of Koha, where removing the contents of the BorrowersTitles preference doesn't affect patron data. I do agree that it is confusing!
Two queries from testing: 1) Does the Description (OPAC) text for the authorized value appear anywhere? I had two different values for Description and Description (OPAC). On the OPAC I could only see what is in the Description. 2) I'm getting this error when trying to search in OPAC and staff interface (even though it is not in the test plan) - can post the full error somewhere if required: > Error trace > DBIx::Class::Storage::DBI::_dbh_execute(): 'localization.translation' isn't in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 130 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 > in DBIx::Class::Exception::throw at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Otherwise, everything works as expected.
Patch no longer applies 8-(
Created attachment 98656 [details] [review] Bug 11815: Convert BorrowersTitles to an authorised value This patch removes the BorrowersTitles system preference in favor of using authorized values to store patron titles. To test, apply the patch and run the database update. - In Administration -> Authorized values, locate the category 'PATRON_TITLE'. - Create two or more authorized values with new patron titles. - In Administration -> System preferences -> Patrons, there should be no entry for BorrowersTitles. - Create or edit a patron. Under "Salutation" your authorized values should appear correctly. - Log in to the OPAC and go to "Your personal details." Confirm that the correct values are shown there. - Remove all PATRON_TITLE authorized values and confirm that the "Salutation" field no longer appears on the staff client or OPAC patron entry form.
Created attachment 98657 [details] [review] Bug 11815: Convert BorrowersTitles to an authorised value This patch removes the BorrowersTitles system preference in favor of using authorized values to store patron titles. To test, apply the patch and run the database update. - In Administration -> Authorized values, locate the category 'PATRON_TITLE'. - Create two or more authorized values with new patron titles. - In Administration -> System preferences -> Patrons, there should be no entry for BorrowersTitles. - Create or edit a patron. Under "Salutation" your authorized values should appear correctly. - Log in to the OPAC and go to "Your personal details." Confirm that the correct values are shown there. - Remove all PATRON_TITLE authorized values and confirm that the "Salutation" field no longer appears on the staff client or OPAC patron entry form.
Created attachment 98668 [details] [review] Bug 11815: Convert BorrowersTitles to an authorised value This patch removes the BorrowersTitles system preference in favor of using authorized values to store patron titles. To test, apply the patch and run the database update. - In Administration -> Authorized values, locate the category 'PATRON_TITLE'. - Create two or more authorized values with new patron titles. - In Administration -> System preferences -> Patrons, there should be no entry for BorrowersTitles. - Create or edit a patron. Under "Salutation" your authorized values should appear correctly. - Log in to the OPAC and go to "Your personal details." Confirm that the correct values are shown there. - Remove all PATRON_TITLE authorized values and confirm that the "Salutation" field no longer appears on the staff client or OPAC patron entry form. Signed-off-by: David Nind <david@davidnind.com>
Currently BLOCKED by the dependency on bug 20307.