Bug 11845 - set overlay and import status translatable in addorderiso2709.tt
Summary: set overlay and import status translatable in addorderiso2709.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 09:53 UTC by Fridolin Somers
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 11845 - set overlay and import status translatable in addorderiso2709.tt (4.00 KB, patch)
2014-02-26 10:08 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 11845 - set overlay and import status translatable in addorderiso2709.tt (4.06 KB, patch)
2014-03-05 14:51 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 11845 - set overlay and import status translatable in addorderiso2709.tt (4.26 KB, patch)
2014-03-12 14:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2014-02-26 09:53:59 UTC
In addorderiso2709.tt, the text for overlay and import status come from database and is not translatable.
Same has Bug 10170.
Comment 1 Fridolin Somers 2014-02-26 10:08:32 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-03-05 14:51:09 UTC
Patch tested with a sandbox, by Nathalie CHATILLON <nathalie.chatillon@uhb.fr>
Comment 3 Biblibre Sandboxes 2014-03-05 14:51:29 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2014-03-12 14:57:11 UTC
Created attachment 26188 [details] [review]
Bug 11845 - set overlay and import status translatable in addorderiso2709.tt

In addorderiso2709.tt, the text for overlay and import status come from database and is not translatable.
Same as Bug 10170.

Test plan :
- Go to acquisition module
- Display an open basket
- Click on "From a staged file"
- Look at table
=> Without patch, you see codes in "Status" column : staged, imported, ...
=> With patch, you see descriptions in "Status" column : Staged, Imported, ...
- Click on a "Add orders"
- Look at table
=> Without patch, you see codes in "Match?" column : no_match, auto_match, ...
=> With patch, you see descriptions in "Match?" column : No match, Match found, ...

Signed-off-by: Nathalie CHATILLON <nathalie.chatillon@uhb.fr>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This is an improvement. Only the translation of auto_match as Match found
could perhaps be further improved.
Comment 5 Galen Charlton 2014-03-12 18:21:06 UTC
Pushed to master.  Thank, Fridolin!
Comment 6 Fridolin Somers 2014-06-12 07:22:17 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 7 Kyle M Hall (khall) 2014-06-13 12:34:12 UTC
Pushed to 3.12.x, will be in 3.12.13