Display basketgroup closed date at OPAC under "Acquisition Details" tab, on detail page.
Created attachment 25639 [details] [review] Bug 11847: Display basketgroup closed date at OPAC under "Acquisition Details" tab, on detail page.
Depends on bug 11169 and bug 11708
I think I can see why a library might want an "Acquisition Details" tab, but it seems a bit...transparent? I don't know if all libraries would want all the details of their orders to show up in the OPAC.
(In reply to David Cook from comment #3) > I think I can see why a library might want an "Acquisition Details" tab, but > it seems a bit...transparent? I don't know if all libraries would want all > the details of their orders to show up in the OPAC. I am wondering that myself -- see my comment on bug 11169.
The problem I see here is that not all libraries are using basket groups. I even think that most libraries don't use basket groups, so the group is never closed and there would never be a order date showing up. I like Galen's idea to style this information more 'patron friendly'. I also agree that not all libraries want that much transparency, because patrons will come and ask a lot for a book, when they see it has been ordered a while ago, often not understanding why it can take a lot of time sometimes. In case we show a date, I think we also need to take into account the basket closed date.
I'm setting this one to In Discussion due to the discussion in bug 11169
This needs some work as bug 11169 do not introduce the new tab.
Created attachment 30445 [details] [review] Bug 11847: Display basketgroup closed date at OPAC in Holdings table, on detail page. Test plan: 1/ Enable OPACAcquisitionDetails syspref 2/ Set AcqCreateItem syspref to "ordering" 3/ Create a basket with 1 order, close this basket then create a basketgroup with this basket and close the basketgroup 4/ Create another basket with 1 order on the same biblio record as previous order. Close the basket then create a basketgroup with this basket but do not close it. 5/ Go to the OPAC detail page of the biblio record. 6/ In holdings table, under "Status" column, you should see: - for the first item ordered: "On order since DATE" - for the second item ordered: "On order"
Created attachment 30480 [details] [review] Bug 11847: Display basketgroup closed date at OPAC in Holdings table, on detail page. Test plan: 1/ Enable OPACAcquisitionDetails syspref 2/ Set AcqCreateItem syspref to "ordering" 3/ Create a basket with 1 order, close this basket then create a basketgroup with this basket and close the basketgroup 4/ Create another basket with 1 order on the same biblio record as previous order. Close the basket then create a basketgroup with this basket but do not close it. 5/ Go to the OPAC detail page of the biblio record. 6/ In holdings table, under "Status" column, you should see: - for the first item ordered: "On order since DATE" - for the second item ordered: "On order" Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I am sorry, bit this seems to explode in a perl error if you choose to not attach your closed basket to a basket group (not checking the checkbox when closing the basket): basketgroup id is required to edit a basketgroup at /home/katrin/kohaclone/C4/Acquisition.pm line 1001.
Hm, maybe I can also add a small request? Could you put the new text into a span with an id? This way libraries that don't want to show the order date can hide it with CSS.
Created attachment 32079 [details] [review] Bug 11847: Add span with class around order date so libraries can hide it if they want
(In reply to Katrin Fischer from comment #10) > I am sorry, bit this seems to explode in a perl error if you choose to not > attach your closed basket to a basket group (not checking the checkbox when > closing the basket): > > basketgroup id is required to edit a basketgroup at > /home/katrin/kohaclone/C4/Acquisition.pm line 1001. I am not able to reproduce this. Could you test it again on recent master ?
Created attachment 32088 [details] [review] Bug 11847: Add span with class around order date so libraries can hide it if they want Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
This is currently blocked by its dependency on 11708 (Patch doesn't apply)
This patch has a dependency on bug 11708 that doesn't apply, Julian, can you please check?
Bug 11708 rebased.
There's a merge conflict with item-status.inc
Created attachment 36922 [details] [review] Bug 11847: Display basketgroup closed date at OPAC Rebased on master
Created attachment 36923 [details] [review] Bug 11847: Add span with class around order date Rebased on master
Moving to Blocked. One of the dependencies listed is in FQA