Bug 11869 - Add more informations to the member printing pages.
Summary: Add more informations to the member printing pages.
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Frédérick Capovilla
QA Contact: Testopia
Depends on:
Reported: 2014-02-27 21:25 UTC by Frédérick Capovilla
Modified: 2014-12-07 20:07 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Add more informations to the account printing pages. (4.06 KB, patch)
2014-02-27 21:25 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
New version of the patch. (4.06 KB, patch)
2014-02-28 16:31 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
New version of the patch. (3.42 KB, patch)
2014-03-07 17:01 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11869 - Add more informations to the account printing page (4.22 KB, patch)
2014-03-30 02:48 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 11869 - Add more informations to the account printing page (4.34 KB, patch)
2014-04-17 18:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2014-02-27 21:25:47 UTC Comment hidden (obsolete)
Comment 1 Frédérick Capovilla 2014-02-27 22:01:51 UTC
To test :
* Create a member profile with a full address and add some fines and payments to it.
* Go to the details page for this member and click on "Print"->"Print summary".
* The page should include the informations mentioned in my previous post.
* Go back to the details page and click on "Print" -> "Print slip"
* The page should include the address of the member.
Comment 2 Mark Tompsett 2014-02-28 14:59:28 UTC
Why did you change the order of things? todaysdate followed the cardnumber link before. Why did you not just insert the address line?

Also, C4::Dates::format_date($accountline->{date}); -- Why not just pass the date, and use the KohaDate plug in in the template to make sure it is formatted correctly?
Comment 3 Frédérick Capovilla 2014-02-28 16:31:04 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2014-02-28 20:56:09 UTC
I can't trigger the moremember-receipts.tt template. The print slip triggers members/printslip.pl which uses circ/printslip.tt. This change was affected by bug 7001 as far as I can tell. This means you've modified the wrong template file for the second part of your patch.
Comment 5 Mark Tompsett 2014-02-28 20:58:50 UTC
Comment on attachment 25726 [details] [review]
New version of the patch.

Review of attachment 25726 [details] [review]:

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
@@ +24,4 @@
>  <li>[% IF ( email ) %][% email %][% ELSE %](no primary email on file)[% END %]</li>
>  [% IF ( emailpro ) %]<li>[% emailpro %]</li>[% END %]
>  </ul>
> +<ul>

I think deleting lines 26 and 27 would be okay.

@@ +120,5 @@
> +            <td colspan="2">[% totaldue %]</td>
> +        </tr>
> +    </tfoot>
> +</table>
> +[% END %]


::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt
@@ +19,4 @@
>  [% IF ( branchname ) %][% branchname %]<br />[% END %]
>  Checked out to [% firstname %] [% surname %] <br />
>  (<a href="/cgi-bin/koha/circ/circulation.pl?findborrower=[% cardnumber %]">[% cardnumber %]</a>)<br />
> +Address: [% address %]<br />

As far as I can tell, there is no way to trigger this template any more. Check circ/printslip.tt?
Comment 6 Frédérick Capovilla 2014-03-07 17:01:23 UTC Comment hidden (obsolete)
Comment 7 Mark Tompsett 2014-03-07 17:59:50 UTC
This looks better, but I was wondering if you could also tweak issueloo.date_due to also pipe through $KohaDates. It displays ugly, and since we're tweaking the summary, we might as well fix that too. After all, [% USE KohaDates %] was added. :)
Comment 8 Aleisha Amohia 2014-03-11 04:47:19 UTC
The 'print summary' part works.
The 'print slip' part says it should show an address but doesn't, however an address shows in 'print summary'.
Comment 9 Mark Tompsett 2014-03-17 17:54:11 UTC
I don't think it should be Failed QA, since slips are now separately configurable (see comment #6).
Comment 10 Mark Tompsett 2014-03-30 02:48:26 UTC Comment hidden (obsolete)
Comment 11 Katrin Fischer 2014-03-31 20:27:02 UTC
Hi Frédérick, please assign bugs you have patches for to yourself, thx!
Comment 12 Katrin Fischer 2014-04-17 18:36:50 UTC
Created attachment 27269 [details] [review]
[PASSED QA] Bug 11869 - Add more informations to the account printing page

This patch adds additional informations to the "Print summary"
and the "Print receipt" templates.

Additional information in "Print summary":
* Registration date
* Expiration date
* Library
* Category
* Fines and payments

1) Go to a patron.
2) Make sure they have something checked out.
3) Manually add a fine.
4) Under the 'Print' button click 'Print summary'
   -- the resulting preview should:
   a) have the first for things listed above, and
   b) have a new fines and payments section.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

NOTE: The due date of the check out is not part of this patch,
      and so I signed off. Similarly, anything required for
      slips is configurable elsewhere now and thus comment 1
      does not accurately reflect the intent of this patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as described and passes all tests and the QA script.
Comment 13 Galen Charlton 2014-04-18 15:51:25 UTC
Pushed to master, along with a follow-up that causes the fines and payments table to display only lines that have an outstanding balance, and which omits the table entirely if the patron has a zero net balance.

The reason for this follow-up is to make it consistent with the logic governing the display of the checkout and hold requests table.

If you really need historical fine data to be included in the printout, please open a new bug for discussion.

Thanks, Frédérick!