When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g, quantity or vendor price).
Created attachment 25978 [details] [review] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved.
Created attachment 26037 [details] [review] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 26525 [details] [review] [PASSED QA] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script.
Pushed to master. Thanks, Jacek!
Pushed to 3.14.x, will be in 3.14.10