Bug 11955 - Remove spaces in empty indicators after linking an authority to a biblio record.
Summary: Remove spaces in empty indicators after linking an authority to a biblio record.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Frédérick Capovilla
QA Contact: Marcel de Rooy
URL:
Keywords:
: 11697 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-18 20:22 UTC by Frédérick Capovilla
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Remove spaces in empty indicators when linking an authority to a biblio record. (897 bytes, patch)
2014-03-18 20:22 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
[SIGNED-OFF] Remove spaces in empty indicators when linking an authority to a biblio record. (1.31 KB, patch)
2014-04-13 21:13 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record. (1.63 KB, patch)
2014-04-17 07:47 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2014-03-18 20:22:16 UTC Comment hidden (obsolete)
Comment 1 Mark Tompsett 2014-03-19 18:06:57 UTC
*** Bug 11697 has been marked as a duplicate of this bug. ***
Comment 2 Bernardo Gonzalez Kriegel 2014-04-13 21:13:28 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-04-17 07:47:18 UTC
Created attachment 27227 [details] [review]
Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record.

This patch removes spaces in indicators which are imported when we link an
authority to a biblio record. The spaces made the indicators harder to edit
after the linking, because we had to delete the superfluous space character
before a new value could be entered.

To test:
1. Open some authority on editor, save with empty indicators.
   They are saved as ind1=" " ind2=" " on auth_header tables, with spaces
2. Edit some record, link some tag with previous auth,
   indicators now have a space on it (or ind1 at last)
3. Apply the patch
4. repeat 2, space is gone

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No koha-qa errors.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Galen Charlton 2014-04-18 15:52:44 UTC
Pushed to master.  Thanks, Frédérick!
Comment 5 Fridolin Somers 2014-08-06 09:59:50 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 6 Kyle M Hall 2014-08-13 14:32:35 UTC
Picked for 3.12.15!