For biblio DOM indexing (which, AFAIRC, is now default setting for new installations), tags "searching" in OPAC doesn't work properly. Clicking on any tag in OPAC (within "Tag cloud", or within "Tags from this library: " in any given biblio) leads to 404 error in browser, and ERROR DECODING RECORD - :1: parser error : Start tag expected, '<' not found ... at /home/koha/devkohaclone/C4/Search.pm line 1724. in error.log. I guess underlying cause for this error is this kludge in opac/opac-search.pl: 504: my @marclist = (map {$_->{marc}} @biblist ); 506: $results_hashref->{biblioserver}->{RECORDS} = \@marclist; which doesn't work any longer in cases when retrieval format being used for biblio records may now be not neceserilly marc, but also xml / marcxml.
Created attachment 26528 [details] [review] Bug 11986 - Tags searching doesn't work in OPAC if biblio DOM indexing is being used This patch fixes the following issue: in installations that are using zebra DOM indexing for bibliographic records, tag searching in OPAC doesn't work properly (clicking on any tag in OPAC leads to "404 error"). To test: ensure that with patch applied: 1) problems with tag searching get resolved for [some] test configuration with biblio DOM indexing enabled, 2) there are no apparent tag-searching-related regressions in OPAC, in some yet another test installation configured with legacy (grs1) indexing mode for biblios.
Created attachment 27534 [details] [review] Bug 11986 - Tags searching doesn't work in OPAC if biblio DOM indexing is being used This patch fixes the following issue: in installations that are using zebra DOM indexing for bibliographic records, tag searching in OPAC doesn't work properly (clicking on any tag in OPAC leads to "404 error"). To test: ensure that with patch applied: 1) problems with tag searching get resolved for [some] test configuration with biblio DOM indexing enabled, 2) there are no apparent tag-searching-related regressions in OPAC, in some yet another test installation configured with legacy (grs1) indexing mode for biblios. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 27629 [details] [review] [PASSED QA] Bug 11986 - Tags searching doesn't work in OPAC if biblio DOM indexing is being used This patch fixes the following issue: in installations that are using zebra DOM indexing for bibliographic records, tag searching in OPAC doesn't work properly (clicking on any tag in OPAC leads to "404 error"). To test: ensure that with patch applied: 1) problems with tag searching get resolved for [some] test configuration with biblio DOM indexing enabled, 2) there are no apparent tag-searching-related regressions in OPAC, in some yet another test installation configured with legacy (grs1) indexing mode for biblios. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Jacek!