Bug 12003 - Next issues for irregular pattern not correctly predicted
Summary: Next issues for irregular pattern not correctly predicted
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low major (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on: 7688 11637
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-26 21:36 UTC by Katrin Fischer
Modified: 2015-06-04 23:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12003: Do not calculate next pubdate for irregular subscriptions (9.08 KB, patch)
2014-03-28 14:01 UTC, Julian Maurice
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12003: Do not calculate next pubdate for irregular subscriptions (9.19 KB, patch)
2014-04-12 15:05 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12003: Do not calculate next pubdate for irregular subscriptions (9.97 KB, patch)
2014-04-15 20:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-03-26 21:36:27 UTC
To test:

1) Create a subscription in the serials module. Make sure to choose: Frequency = Irregular
2) Test the prediction pattern, publication date will show as 'unknown'
3) Save the subscription
4) Check the created issue - it will show a published date and a planned date, but those should be 'unknown'
5) Receive the issue and check the next generated issue, it will have dates set
6) Generate a next issue, it will also be created with dates set


This is a regression to how this worked previously and should be fixed. Also prediction pattern and actual behaviour don't match now.
Comment 1 Julian Maurice 2014-03-28 14:01:42 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-04-12 15:05:36 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-04-15 20:42:40 UTC
Created attachment 27146 [details] [review]
[PASSED QA] Bug 12003: Do not calculate next pubdate for irregular subscriptions

Show 'Unknown' when planneddate and publisheddate cannot be calculated

Also fixes SQL query in misc/cronjobs/serialsUpdate.pl that was still
using "periodicity != 32" to exclude irregular subscriptions from
results

Test plan:

1) Create a subscription in the serials module. Make sure to choose:
   Frequency = Irregular
2) Test the prediction pattern, first publication date is set to
   "First issue publication date" field, others will show as
   'unknown'
3) Save the subscription
4) Check the created issue - it will show a published date and a
   planned date (same as "First issue publication date" field)
5) Receive the issue and check the next generated issue, planned
   date and published date should show as 'Unknown'
6) Generate a next issue, planned date and published date should
   also show as 'Unknown'

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described following test plan.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Also tested:
- multi receiving generates mulitple issues without dates - 'unknown'
- staff detail page shows the dates empty, which is fine
- OPAC detail page shows the dates empty, which is fine
- serial collection page shows 'unknown' and those issues appear
  on the 'manage' tab, as they did in the past
- Editing the issue from the serial collection page leaves the
  date fields empty.
- Receving the issue, setting the status to 'Arrived' the Expected on
  date is set to 'today' automatically. Date published has to be
  entered manually (maybe something we could improve later
- subscription detail > issues tab shows Uknown.
- t/db_dependent/Serials/GetNextDate.t pass.
Comment 4 Galen Charlton 2014-04-18 21:03:19 UTC
Pushed to master.  Thanks, Julian!
Comment 5 Fridolin Somers 2014-08-06 10:25:33 UTC
Pushed to 3.14.x, will be in 3.14.10