Bug 12022 - Independent branches does not isolate pending and approved comments by branch.
Summary: Independent branches does not isolate pending and approved comments by branch.
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-01 22:00 UTC by Barton Chittenden
Modified: 2023-07-15 18:34 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12022 - Independent branches does not isolate pending and approved comments by branch. (2.42 KB, patch)
2014-04-10 14:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12022 - Independent branches does not isolate pending and approved comments by branch. (2.55 KB, patch)
2014-04-10 14:33 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12022 - Independent branches does not isolate pending and approved comments by branch. (3.74 KB, patch)
2016-08-23 17:44 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2014-04-01 22:00:38 UTC
Given Branches A and B

Branch A patron logs on to OPAC and leaves a comment for a title.
Branch B staff is then able to see these comments in Home > Tools > Comments > Approved comments, in both the "Approved Comments" and "Comments awaiting moderation" tabs.
Comment 1 Kyle M Hall 2014-04-10 14:29:29 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-04-10 14:33:00 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-04-11 17:25:29 UTC
Looks like something has been left out of the patch?

Undefined subroutine &C4::Review::GetIndependentGroupModificationRights called at C4/Review.pm line 141.
Comment 4 Marc Véron 2015-12-24 13:52:31 UTC
Is this bug still valid?
Comment 5 Katrin Fischer 2016-08-14 15:19:53 UTC
Commit message mentions a depending bug that was marked as WONTFIX - Kyle, could you take a look here maybe?

My feeling is that the behaviour might still be desirable, but we'd need a restart on the patches?
Comment 6 Kyle M Hall 2016-08-23 17:44:57 UTC
Created attachment 54785 [details] [review]
Bug 12022 - Independent branches does not isolate pending and approved comments by branch.

Test Plan:
1) Create some comments for two libraries
2) Log in as non-superlibrarian
3) Set the logged in library to one of those two libraries
4) View comments, not you only see the comments from patrons
   whose home library matches the logged in library
5) Log in as a superlibrarian
6) Note you see all the comments reguardless of the patron's
   home library
Comment 7 Kyle M Hall 2016-08-23 17:59:41 UTC
My new patch just filters based on if the librarian is a superlibrarian or not. I imagine this would be nice outside of enabling IndependentBranches. If someone disagrees, please let me know ; )
Comment 8 Katrin Fischer 2016-08-24 19:50:46 UTC
Hi Kyle, sorry, but I think this behaviour change will possibly upset some libraries. Could we tie it to IndyBranches - or a new pref? There is another example where the latter has been done: IndependentBranchesPatronModifications
Comment 9 Martin Renvoize 2020-02-07 12:20:46 UTC
Is this still valid.. or perhaps it should really be moved to library groups rather than independent branches at this point?

At this point, it feels like an enhancement to me?