Given Branches A and B Branch A patron logs on to OPAC and leaves a comment for a title. Branch B staff is then able to see these comments in Home > Tools > Comments > Approved comments, in both the "Approved Comments" and "Comments awaiting moderation" tabs.
Created attachment 26979 [details] [review] Bug 12022 - Independent branches does not isolate pending and approved comments by branch. Given Branches A and B Branch A patron logs on to OPAC and leaves a comment for a title. Branch B staff is then able to see these comments in Home > Tools > Comments > Approved comments, in both the "Approved Comments" and "Comments awaiting moderation" tabs. Test Plan: 1) Create some comments for two libraries 2) Enable IndependentBranches 3) View the comments, not you see comments from both library's patrons 4) Apply the patch for bug 10276 5) Apply this patch 6) View the comments again, note you only see the comments for the patrons of the library you are logged in as.
Created attachment 26980 [details] [review] Bug 12022 - Independent branches does not isolate pending and approved comments by branch. Given Branches A and B Branch A patron logs on to OPAC and leaves a comment for a title. Branch B staff is then able to see these comments in Home > Tools > Comments > Approved comments, in both the "Approved Comments" and "Comments awaiting moderation" tabs. Test Plan: 1) Create some comments for two libraries 2) Enable IndependentBranches 3) View the comments, not you see comments from both library's patrons 4) Apply the patch for bug 10276 5) Apply this patch 6) View the comments again, note you only see the comments for the patrons of the library you are logged in as.
Looks like something has been left out of the patch? Undefined subroutine &C4::Review::GetIndependentGroupModificationRights called at C4/Review.pm line 141.
Is this bug still valid?
Commit message mentions a depending bug that was marked as WONTFIX - Kyle, could you take a look here maybe? My feeling is that the behaviour might still be desirable, but we'd need a restart on the patches?
Created attachment 54785 [details] [review] Bug 12022 - Independent branches does not isolate pending and approved comments by branch. Test Plan: 1) Create some comments for two libraries 2) Log in as non-superlibrarian 3) Set the logged in library to one of those two libraries 4) View comments, not you only see the comments from patrons whose home library matches the logged in library 5) Log in as a superlibrarian 6) Note you see all the comments reguardless of the patron's home library
My new patch just filters based on if the librarian is a superlibrarian or not. I imagine this would be nice outside of enabling IndependentBranches. If someone disagrees, please let me know ; )
Hi Kyle, sorry, but I think this behaviour change will possibly upset some libraries. Could we tie it to IndyBranches - or a new pref? There is another example where the latter has been done: IndependentBranchesPatronModifications
Is this still valid.. or perhaps it should really be moved to library groups rather than independent branches at this point? At this point, it feels like an enhancement to me?