Bug 12062 - Untranslatable "Reserve not found"
Summary: Untranslatable "Reserve not found"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-10 08:41 UTC by paxed
Modified: 2015-06-04 23:33 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12062 - Untranslatable "Reserve not found" (2.66 KB, patch)
2014-04-22 11:48 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12062 - Untranslatable "Reserve not found" (2.71 KB, patch)
2014-04-22 13:54 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12062 - Untranslatable "Reserve not found" (2.82 KB, patch)
2014-04-22 17:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12062 - Follow up to fix more untraslatable cases (4.85 KB, patch)
2014-04-29 19:38 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12062 - Follow up to fix more untraslatable cases (4.85 KB, patch)
2014-04-29 19:39 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12062 - Follow up to fix more untraslatable cases (4.85 KB, patch)
2014-04-30 11:00 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12062 - Follow up to fix more untraslatable cases (4.92 KB, patch)
2014-07-03 05:23 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 12062 - Untranslatable "Reserve not found" (2.85 KB, patch)
2014-07-06 17:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12062 - Follow up to fix more untraslatable cases (4.99 KB, patch)
2014-07-06 17:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12062: Follow up - adds missing ) (1.25 KB, patch)
2014-07-06 17:20 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-04-10 08:41:44 UTC
circ/hold-transfer-slip.pl:    $slip = "Reserve not found";

The same file also has the title hardcoded as "Koha -- Circulation: Transfers"
Comment 1 Bernardo Gonzalez Kriegel 2014-04-22 11:48:28 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-04-22 12:58:19 UTC
This patch really ought to update the text to use the correct term: 'hold' instead of 'reserve.'

While you're at it, the page title ought to conform to other pages:

Koha › Circulation › Transfers

Not a big deal, but consistency is good.
Comment 3 Bernardo Gonzalez Kriegel 2014-04-22 13:54:46 UTC Comment hidden (obsolete)
Comment 4 Bernardo Gonzalez Kriegel 2014-04-22 13:59:34 UTC
(In reply to Owen Leonard from comment #2)
> Not a big deal, but consistency is good.

Of course :)
New patch to test.
Comment 5 Owen Leonard 2014-04-22 17:46:58 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2014-04-25 13:54:17 UTC
printslip.tt is used by circ/transfer-slip.pl, members/printslip.pl and opac/sco/printslip.pl as well as circ/hold-transfer-slip.pl

The fixed title will not work here. You'll need to add a flag and title for each of these scripts to the template so each can have a separate translatable title.
Comment 7 Bernardo Gonzalez Kriegel 2014-04-29 19:38:04 UTC Comment hidden (obsolete)
Comment 8 Bernardo Gonzalez Kriegel 2014-04-29 19:39:40 UTC Comment hidden (obsolete)
Comment 9 paxed 2014-04-30 08:14:27 UTC
<title>Koha &rsaquo; Members &rsaquo; Print receipt for [%- borrowernumber -%]</title>

The [%- will eat away the space between the "for" and the borrowernumber.
Comment 10 Bernardo Gonzalez Kriegel 2014-04-30 11:00:05 UTC Comment hidden (obsolete)
Comment 11 Bernardo Gonzalez Kriegel 2014-04-30 11:00:45 UTC
(In reply to paxed from comment #9)
> <title>Koha &rsaquo; Members &rsaquo; Print receipt for [%- borrowernumber
> -%]</title>
> 
> The [%- will eat away the space between the "for" and the borrowernumber.

Thanks, now is fixed.
Comment 12 Jonathan Druart 2014-05-22 15:01:34 UTC
Not sure it is pertinent, but bug 12043 impacts the same templates.
Comment 13 Chris Cormack 2014-07-03 05:23:55 UTC Comment hidden (obsolete)
Comment 14 Katrin Fischer 2014-07-06 17:03:41 UTC
The QA script points out a problem with these patches:
 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
   OK	  tt_valid
   FAIL	  valid_template
		parse error - /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt line 3: unexpected end of directive
  [% IF ( caller = 'hold-transfer' %]

I am fixing this in a follow up.
Comment 15 Katrin Fischer 2014-07-06 17:20:28 UTC
Created attachment 29515 [details] [review]
[PASSED QA] Bug 12062 - Untranslatable "Reserve not found"

This patch rewrites transfer slip code to make some
strings translatable.
Also simplifies some code and parameters.

To test:
1) Produce a transfer slip, no changes must be noted.

2) Update PO file, new strings
msgid "%s %s%s%sNo hold found%s %s %s "
msgid "%s%s%sNo hold found%s "
msgid "Koha &rsaquo; Circulation &rsaquo; Transfers"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 16 Katrin Fischer 2014-07-06 17:20:33 UTC
Created attachment 29516 [details] [review]
[PASSED QA] Bug 12062 - Follow up to fix more untraslatable cases

This patch modifies staff printslip.tt to take into account
caller. Also fixes similar problem on opac printslip.tt

To test:
staff
1. Print hold transfer slip
2. Print transfer slip
3. Print member slip
opac
4. Print self checkout slip

5. Update translation files, check new strings are present

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 17 Katrin Fischer 2014-07-06 17:20:37 UTC
Created attachment 29517 [details] [review]
Bug 12062: Follow up - adds missing )

With this patch, patches pass QA script and unit tests.
Tested printing different slips successfully.
Comment 18 Tomás Cohen Arazi 2014-07-07 14:02:07 UTC
Patches pushed to master.

Thanks Bernardo and Katrina!