circ/hold-transfer-slip.pl: $slip = "Reserve not found"; The same file also has the title hardcoded as "Koha -- Circulation: Transfers"
Created attachment 27397 [details] [review] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update por file, new strings 'Koha -- Circulation: Transfers' and 'Reserve not found' must be present
This patch really ought to update the text to use the correct term: 'hold' instead of 'reserve.' While you're at it, the page title ought to conform to other pages: Koha › Circulation › Transfers Not a big deal, but consistency is good.
Created attachment 27401 [details] [review] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers"
(In reply to Owen Leonard from comment #2) > Not a big deal, but consistency is good. Of course :) New patch to test.
Created attachment 27430 [details] [review] [SIGNED-OFF] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
printslip.tt is used by circ/transfer-slip.pl, members/printslip.pl and opac/sco/printslip.pl as well as circ/hold-transfer-slip.pl The fixed title will not work here. You'll need to add a flag and title for each of these scripts to the template so each can have a separate translatable title.
Created attachment 27780 [details] [review] Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present
Created attachment 27782 [details] [review] Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present
<title>Koha › Members › Print receipt for [%- borrowernumber -%]</title> The [%- will eat away the space between the "for" and the borrowernumber.
Created attachment 27818 [details] [review] Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present
(In reply to paxed from comment #9) > <title>Koha › Members › Print receipt for [%- borrowernumber > -%]</title> > > The [%- will eat away the space between the "for" and the borrowernumber. Thanks, now is fixed.
Not sure it is pertinent, but bug 12043 impacts the same templates.
Created attachment 29463 [details] [review] Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
The QA script points out a problem with these patches: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt OK tt_valid FAIL valid_template parse error - /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt line 3: unexpected end of directive [% IF ( caller = 'hold-transfer' %] I am fixing this in a follow up.
Created attachment 29515 [details] [review] [PASSED QA] Bug 12062 - Untranslatable "Reserve not found" This patch rewrites transfer slip code to make some strings translatable. Also simplifies some code and parameters. To test: 1) Produce a transfer slip, no changes must be noted. 2) Update PO file, new strings msgid "%s %s%s%sNo hold found%s %s %s " msgid "%s%s%sNo hold found%s " msgid "Koha › Circulation › Transfers" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 29516 [details] [review] [PASSED QA] Bug 12062 - Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 29517 [details] [review] Bug 12062: Follow up - adds missing ) With this patch, patches pass QA script and unit tests. Tested printing different slips successfully.
Patches pushed to master. Thanks Bernardo and Katrina!