Bug 12075 - jQueryUI upgrade broke keyboard shortcuts
Summary: jQueryUI upgrade broke keyboard shortcuts
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-11 16:36 UTC by Owen Leonard
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12075 - jQueryUI upgrade broke keyboard shortcuts (3.47 KB, patch)
2014-04-11 16:45 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts (3.62 KB, patch)
2014-04-14 11:33 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts (3.79 KB, patch)
2014-04-14 21:06 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-04-11 16:36:45 UTC
The latest jQueryUI upgrade removed the option to trigger a tab select based on its name. The only built-in option is to select a tab based on its index. Since the index of the keyboard-shortcutted tabs varies depending on which page you're on another solution is required. This is what worked for me:

http://stackoverflow.com/questions/14859281/select-tab-by-name-in-jquery-ui-1-10-0/16550804#16550804
Comment 1 Owen Leonard 2014-04-11 16:45:28 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-04-14 11:33:27 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-04-14 21:06:45 UTC
Created attachment 27106 [details] [review]
[PASSED QA] Bug 12075 - jQueryUI upgrade broke keyboard shortcuts

The recent jQueryUI upgrade broke keyboard shortcuts in the staff client
because of changes to the jQueryUI API. This patch fixes the problem.

To test, apply the patch and clear your browser cache if necessary.

- View any page in the staff which includes header search tabs for check out,
  check in, or catalog search (staff client home page or circulation
  page for instance).
- Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check
  out, Alt-r for check in.
- Each keyboard shortcut should select the correct tab.

Followed test plan, patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Confirmed that the shortcuts were broken before the patch
and now work again after applying it.
Comment 4 Galen Charlton 2014-04-14 23:59:16 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-08-06 09:13:34 UTC
Pushed to 3.14.x, will be in 3.14.10