Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory
Summary: Move checkboxes jQuery plugin outside of language-specific directory
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-18 16:13 UTC by Owen Leonard
Modified: 2014-12-07 20:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory (19.82 KB, patch)
2014-04-18 18:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory (19.91 KB, patch)
2014-04-24 01:11 UTC, David Cook
Details | Diff | Splinter Review
[PASSED QA] Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory (19.97 KB, patch)
2014-04-25 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-04-18 16:13:58 UTC
The checkboxes jQuery plugin should be moved to intranet-tmpl/lib/jquery/plugins so that it doesn't have to be duplicated for each translation.
Comment 1 Owen Leonard 2014-04-18 18:49:05 UTC Comment hidden (obsolete)
Comment 2 David Cook 2014-04-24 01:11:13 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-04-25 13:25:33 UTC
Created attachment 27624 [details] [review]
[PASSED QA] Bug 12107 - Move checkboxes jQuery plugin outside of language-specific directory

This patch moves the checkboxes jQuery plugin to
intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated
for each set of translated templates.

To test, apply the patch and confirm that select all/clear all controls
continue to work on the following pages:

- Acquisitions -> Late orders
- Acquisitions -> Add to order from an external source (search targets)
- Acquisitions -> Suggestions
- Administration -> Funds -> Planning (show/hide all columns)
  * Some unused code has been removed
- Administration -> Library transfer limits
- Staff client cart
- Authorities -> New from Z39.50 (search targets)
- Cataloging -> New from Z39.50 (search targets)
- Circulation -> Check out to a patron (renew/check in selections)
- Circulation -> Offline circulation -> Pending operations
- Patrons -> Patron detail (renew/check in selections)
- Patrons -> Fines -> Pay fines
- Serials -> Subscription -> Serial collection
- Tools -> Label creator -> Batches -> Search results
- Tools -> Patron card creator -> Batches -> Search results
- Tools -> Tags moderation
- Tools -> Batch item deletion
- Tools -> Batch item modification
- Tools -> Inventory -> Submit a batch of barcodes
- Lists -> List contents view

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works as described! I don't think I've ever checked so many boxes
before...

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2014-04-25 15:38:50 UTC
Pushed to master.  Thanks, Owen!