Bug 12112 - C4::Breeding::ImportBreeding() is not used
Summary: C4::Breeding::ImportBreeding() is not used
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 10998
  Show dependency treegraph
 
Reported: 2014-04-19 21:50 UTC by Galen Charlton
Modified: 2015-06-04 23:30 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12112: remove disused routine C4::Breeding::ImportBreeding() (6.82 KB, patch)
2014-04-20 14:51 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 12112: remove disused routine C4::Breeding::ImportBreeding() (6.92 KB, patch)
2014-04-21 18:00 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[PASSED QA] Bug 12112: remove disused routine C4::Breeding::ImportBreeding() (6.94 KB, patch)
2014-04-25 13:08 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2014-04-19 21:50:00 UTC
Tracing of the code reveals that C4::Breeding::ImportBreeding() is not actually used.

The last call to it was removed by the patch for bug 10462, which replaced it with calls to GetZ3950BatchId() and AddBiblioToBatch().  The continued existence of the routine has caused a bit of confusion -- see the descriptions of some versions of the patch for bug 11254.

The routine should be removed.
Comment 1 Galen Charlton 2014-04-20 14:51:25 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2014-04-21 18:00:46 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-04-25 13:08:56 UTC
Created attachment 27622 [details] [review]
[PASSED QA] Bug 12112: remove disused routine C4::Breeding::ImportBreeding()

This patch removes the ImportBreeding() routine, which lost its
last caller as of the patch for bug 10462.

To test:

[1] Verify that prove -v t/Breeding.t passes.
[2] Perform a Z39.50 search in the staff interface.
[3] Perform a cataloguing reservoir search in the staff
    interface; verifying that cached records from the search
    done in step 2 are retrieved.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2014-04-25 15:39:20 UTC
Pushed to master.
Comment 5 Fridolin Somers 2014-09-17 14:39:55 UTC
Pushed to 3.14.x, will be in 3.14.11