Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory
Summary: Move fixFloat jQuery plugin outside of language-specific directory
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-21 16:00 UTC by Owen Leonard
Modified: 2014-12-07 20:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory (5.66 KB, patch)
2014-04-21 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory (5.88 KB, patch)
2014-04-21 17:03 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory (5.77 KB, patch)
2014-04-25 12:32 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-04-21 16:00:08 UTC
The fixFloat jQuery plugin should be moved to intranet-tmpl/lib/jquery/plugins so that it doesn't have to be duplicated for each translation.
Comment 1 Owen Leonard 2014-04-21 16:44:21 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-04-21 17:03:29 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-04-25 12:32:31 UTC
Created attachment 27616 [details] [review]
[PASSED QA] Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory

This patch moves the fixFloat jQuery plugin to
intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated
for each set of translated templates.

This patch also includes a change to staff-global.css to override some
style the floating toolbar inherited when we added Bootstrap widgets.

To test, apply the patch and confirm that the toolbar "sticks" to the
top of the screen when scrolling down on the following pages:

- System preferences
- Authorities editor (Authorities -> New authority)
- Cataloging editor (Cataloging -> New record)
- List contents view (Lists -> View a list's contents)

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2014-04-25 15:38:27 UTC
Pushed to master.  Thanks, Owen!