Bug 12145 - Lock for Move up buttons with Marc tag
Summary: Lock for Move up buttons with Marc tag
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2014-04-25 18:05 UTC by vimal kumar
Modified: 2023-07-15 19:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions (5.95 KB, patch)
2017-04-28 03:03 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 12145: [FOLLOW-UP] Separating buttons and tags (3.17 KB, patch)
2017-06-02 04:33 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions (6.02 KB, patch)
2017-06-22 13:30 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12145: [FOLLOW-UP] Separating buttons and tags (3.24 KB, patch)
2017-06-22 13:30 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions (6.18 KB, patch)
2017-06-22 14:01 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12145: [FOLLOW-UP] Separating buttons and tags (3.47 KB, patch)
2017-06-22 14:01 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description vimal kumar 2014-04-25 18:05:41 UTC
Dear Developers,
Our staff in cataloguing section have complained about "move up" button with MARC tags in cataloguing sheet. They always accidently click on move up button while cataloguing process. Accidental clicking on move up button change the order of subfileds (26$a,b,c). It make errors in data entry process. 

Our cataloguers suggest a lock option for "Move up" buttons with MARC subfields.
Lock option should be in Gloabl system preferences.
Comment 1 Aleisha Amohia 2017-04-28 03:03:07 UTC
Created attachment 62808 [details] [review]
Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions

This patch adds a syspref LockMoveUpButtons to hide the 'move up'
buttons by default in the MARC editor. There is also a new option in the
settings menu in the MARC editor called 'Lock subfield positions' so
users can toggle the 'move up' buttons in the editor.

To test:
1) Apply patch and update database
2) Find the LockMoveUpButtons syspref in Admin -> Global system
preferences. Confirm it is set to "Don't lock" by default
3) Go to add a new biblio or edit an existing one in cataloguing
4) The Move Up buttons should still be present and work as normal. Click
Settings and confirm the 'Lock subfield positions' option is unchecked
5) Click 'Lock subfield positions' to show and hide the buttons
6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing
editor
7) Confirm the buttons are hidden by default

Sponsored-by: Catalyst IT
Comment 2 Katrin Fischer 2017-05-02 18:31:25 UTC
When "Show tags" is off, toggling "Lock subfield positions" doesn't have any effect. Could you please check?
Comment 3 Aleisha Amohia 2017-06-02 04:33:16 UTC
Created attachment 63906 [details] [review]
Bug 12145: [FOLLOW-UP] Separating buttons and tags

This patch fixes the issue in Comment 2. The move-up buttons were inside
the element that gets hidden when 'Show tags' is off, therefore removing
their functionality and making the 'Lock subfield positions' button
useless. This patch separates the buttons and the tags into two separate
span elements, and adds the appropriate CSS.

To test:
Confirm that 'Lock subfield positions' still works when 'Show tags'
is off.
Comment 4 Biblibre Sandboxes 2017-06-22 13:30:12 UTC
Patch tested with a sandbox, by Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>
Comment 5 Biblibre Sandboxes 2017-06-22 13:30:44 UTC
Created attachment 64539 [details] [review]
Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions

This patch adds a syspref LockMoveUpButtons to hide the 'move up'
buttons by default in the MARC editor. There is also a new option in the
settings menu in the MARC editor called 'Lock subfield positions' so
users can toggle the 'move up' buttons in the editor.

To test:
1) Apply patch and update database
2) Find the LockMoveUpButtons syspref in Admin -> Global system
preferences. Confirm it is set to "Don't lock" by default
3) Go to add a new biblio or edit an existing one in cataloguing
4) The Move Up buttons should still be present and work as normal. Click
Settings and confirm the 'Lock subfield positions' option is unchecked
5) Click 'Lock subfield positions' to show and hide the buttons
6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing
editor
7) Confirm the buttons are hidden by default

Sponsored-by: Catalyst IT

Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>
Comment 6 Biblibre Sandboxes 2017-06-22 13:30:47 UTC
Created attachment 64540 [details] [review]
Bug 12145: [FOLLOW-UP] Separating buttons and tags

This patch fixes the issue in Comment 2. The move-up buttons were inside
the element that gets hidden when 'Show tags' is off, therefore removing
their functionality and making the 'Lock subfield positions' button
useless. This patch separates the buttons and the tags into two separate
span elements, and adds the appropriate CSS.

To test:
Confirm that 'Lock subfield positions' still works when 'Show tags'
is off.

Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>
Comment 7 Biblibre Sandboxes 2017-06-22 14:01:12 UTC
Patch tested with a sandbox, by Israelex A Veleña for KohaCon17 <israelex19@gmail.com>
Comment 8 Biblibre Sandboxes 2017-06-22 14:01:46 UTC
Created attachment 64543 [details] [review]
Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions

This patch adds a syspref LockMoveUpButtons to hide the 'move up'
buttons by default in the MARC editor. There is also a new option in the
settings menu in the MARC editor called 'Lock subfield positions' so
users can toggle the 'move up' buttons in the editor.

To test:
1) Apply patch and update database
2) Find the LockMoveUpButtons syspref in Admin -> Global system
preferences. Confirm it is set to "Don't lock" by default
3) Go to add a new biblio or edit an existing one in cataloguing
4) The Move Up buttons should still be present and work as normal. Click
Settings and confirm the 'Lock subfield positions' option is unchecked
5) Click 'Lock subfield positions' to show and hide the buttons
6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing
editor
7) Confirm the buttons are hidden by default

Sponsored-by: Catalyst IT

Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>

Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com>
Comment 9 Biblibre Sandboxes 2017-06-22 14:01:50 UTC
Created attachment 64544 [details] [review]
Bug 12145: [FOLLOW-UP] Separating buttons and tags

This patch fixes the issue in Comment 2. The move-up buttons were inside
the element that gets hidden when 'Show tags' is off, therefore removing
their functionality and making the 'Lock subfield positions' button
useless. This patch separates the buttons and the tags into two separate
span elements, and adds the appropriate CSS.

To test:
Confirm that 'Lock subfield positions' still works when 'Show tags'
is off.

Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>

Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com>
Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com>
Comment 10 Jonathan Druart 2017-07-13 18:05:49 UTC
I don't think it is the best way to answer the need.

If a library wants to remove the move up buttons it can be achieve easily with JS:
    $('.subfieldmoveup').hide();

Then we could add the checkbox "Lock subfield positions" but the value must be saved in session like we do for the "sticky due date" (see circ/circulation.pl stickyduedate).
Comment 11 Katrin Fischer 2023-07-15 19:03:23 UTC
We removed the arrows since and are now using drag & drop. I wonder if this resolved the issue of accidental clicking/moving things?