Dear Developers, Our staff in cataloguing section have complained about "move up" button with MARC tags in cataloguing sheet. They always accidently click on move up button while cataloguing process. Accidental clicking on move up button change the order of subfileds (26$a,b,c). It make errors in data entry process. Our cataloguers suggest a lock option for "Move up" buttons with MARC subfields. Lock option should be in Gloabl system preferences.
Created attachment 62808 [details] [review] Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions This patch adds a syspref LockMoveUpButtons to hide the 'move up' buttons by default in the MARC editor. There is also a new option in the settings menu in the MARC editor called 'Lock subfield positions' so users can toggle the 'move up' buttons in the editor. To test: 1) Apply patch and update database 2) Find the LockMoveUpButtons syspref in Admin -> Global system preferences. Confirm it is set to "Don't lock" by default 3) Go to add a new biblio or edit an existing one in cataloguing 4) The Move Up buttons should still be present and work as normal. Click Settings and confirm the 'Lock subfield positions' option is unchecked 5) Click 'Lock subfield positions' to show and hide the buttons 6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing editor 7) Confirm the buttons are hidden by default Sponsored-by: Catalyst IT
When "Show tags" is off, toggling "Lock subfield positions" doesn't have any effect. Could you please check?
Created attachment 63906 [details] [review] Bug 12145: [FOLLOW-UP] Separating buttons and tags This patch fixes the issue in Comment 2. The move-up buttons were inside the element that gets hidden when 'Show tags' is off, therefore removing their functionality and making the 'Lock subfield positions' button useless. This patch separates the buttons and the tags into two separate span elements, and adds the appropriate CSS. To test: Confirm that 'Lock subfield positions' still works when 'Show tags' is off.
Patch tested with a sandbox, by Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>
Created attachment 64539 [details] [review] Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions This patch adds a syspref LockMoveUpButtons to hide the 'move up' buttons by default in the MARC editor. There is also a new option in the settings menu in the MARC editor called 'Lock subfield positions' so users can toggle the 'move up' buttons in the editor. To test: 1) Apply patch and update database 2) Find the LockMoveUpButtons syspref in Admin -> Global system preferences. Confirm it is set to "Don't lock" by default 3) Go to add a new biblio or edit an existing one in cataloguing 4) The Move Up buttons should still be present and work as normal. Click Settings and confirm the 'Lock subfield positions' option is unchecked 5) Click 'Lock subfield positions' to show and hide the buttons 6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing editor 7) Confirm the buttons are hidden by default Sponsored-by: Catalyst IT Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>
Created attachment 64540 [details] [review] Bug 12145: [FOLLOW-UP] Separating buttons and tags This patch fixes the issue in Comment 2. The move-up buttons were inside the element that gets hidden when 'Show tags' is off, therefore removing their functionality and making the 'Lock subfield positions' button useless. This patch separates the buttons and the tags into two separate span elements, and adds the appropriate CSS. To test: Confirm that 'Lock subfield positions' still works when 'Show tags' is off. Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com>
Patch tested with a sandbox, by Israelex A Veleña for KohaCon17 <israelex19@gmail.com>
Created attachment 64543 [details] [review] Bug 12145: Add LockMoveUpButtons syspref to lock subfield positions This patch adds a syspref LockMoveUpButtons to hide the 'move up' buttons by default in the MARC editor. There is also a new option in the settings menu in the MARC editor called 'Lock subfield positions' so users can toggle the 'move up' buttons in the editor. To test: 1) Apply patch and update database 2) Find the LockMoveUpButtons syspref in Admin -> Global system preferences. Confirm it is set to "Don't lock" by default 3) Go to add a new biblio or edit an existing one in cataloguing 4) The Move Up buttons should still be present and work as normal. Click Settings and confirm the 'Lock subfield positions' option is unchecked 5) Click 'Lock subfield positions' to show and hide the buttons 6) Set the LockMoveUpButtons syspref to Lock and refresh the cataloguing editor 7) Confirm the buttons are hidden by default Sponsored-by: Catalyst IT Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com>
Created attachment 64544 [details] [review] Bug 12145: [FOLLOW-UP] Separating buttons and tags This patch fixes the issue in Comment 2. The move-up buttons were inside the element that gets hidden when 'Show tags' is off, therefore removing their functionality and making the 'Lock subfield positions' button useless. This patch separates the buttons and the tags into two separate span elements, and adds the appropriate CSS. To test: Confirm that 'Lock subfield positions' still works when 'Show tags' is off. Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com>
I don't think it is the best way to answer the need. If a library wants to remove the move up buttons it can be achieve easily with JS: $('.subfieldmoveup').hide(); Then we could add the checkbox "Lock subfield positions" but the value must be saved in session like we do for the "sticky due date" (see circ/circulation.pl stickyduedate).
We removed the arrows since and are now using drag & drop. I wonder if this resolved the issue of accidental clicking/moving things?