There is HTML code on batchMod.pl In particular an untranslatable "Tag Editor"
Created attachment 27930 [details] [review] Bug 12180 - Remove HTML from batchMod.pl This patch removes HTML code from batchMod.pl To test: 1. Check no regressions on batchMod editor, Go to Tools > Batch item modification, put a know barcode on barcode list, press continue 2. Check new line on translation files, update a language, look for 'Tag editor'
Created attachment 27931 [details] [review] Bug 12180 - Remove HTML from batchMod.pl This patch removes HTML code from batchMod.pl To test: 1. Check no regressions on batchMod editor, Go to Tools > Batch item modification, put a know barcode on barcode list, press continue 2. Check new line on translation files, update a language, look for 'Tag editor' Fixed capitalizacion
Created attachment 30808 [details] [review] [SIGNED-OFF] Bug 12180 - Remove HTML from batchMod.pl This patch removes HTML code from batchMod.pl To test: 1. Check no regressions on batchMod editor, Go to Tools > Batch item modification, put a know barcode on barcode list, press continue 2. Check new line on translation files, update a language, look for 'Tag editor' Fixed capitalizacion Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
The Javascript on the page is broken before and after the patch (bug 12777):( But I also found a regression: without the patch the date accessioned plugin works ok, but with the patch, it doesn't populate the field with the current date.
Created attachment 30867 [details] [review] [SIGNED-OFF] Bug 12180 - Remove HTML from batchMod.pl This patch removes HTML code from batchMod.pl To test: 1. Check no regressions on batchMod editor, Go to Tools > Batch item modification, put a know barcode on barcode list, press continue 2. Check new line on translation files, update a language, look for 'Tag editor' Fixed capitalizacion Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Amended patch, a stupid mistake on line 198 of batchMod-edit.tt - [% javascript %] + [% mv.javascript %]
(In reply to Katrin Fischer from comment #4) > The Javascript on the page is broken before and after the patch (bug 12777):( I left a note on that bug... problem is that later i found it :( But really can't reproduce. If I clean browser cache it disappears. > But I also found a regression: without the patch the date accessioned plugin > works ok, but with the patch, it doesn't populate the field with the current > date. Great QA :) Fixed, was one line, simple fix. I left status as signed, unless you think differently.
Created attachment 30871 [details] [review] [PASSED QA] Bug 12180 - Remove HTML from batchMod.pl This patch removes HTML code from batchMod.pl To test: 1. Check no regressions on batchMod editor, Go to Tools > Batch item modification, put a know barcode on barcode list, press continue 2. Check new line on translation files, update a language, look for 'Tag editor' Fixed capitalisation Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Amended patch, a stupid mistake on line 198 of batchMod-edit.tt - [% javascript %] + [% mv.javascript %] Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Passes tests and QA script.
Patch pushed to master. Thanks Bernardo!