Bug 12180 - Remove HTML from batchMod.pl
Summary: Remove HTML from batchMod.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-04 17:18 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12180 - Remove HTML from batchMod.pl (9.52 KB, patch)
2014-05-04 17:28 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12180 - Remove HTML from batchMod.pl (9.54 KB, patch)
2014-05-04 17:33 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12180 - Remove HTML from batchMod.pl (9.59 KB, patch)
2014-08-15 01:44 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12180 - Remove HTML from batchMod.pl (9.74 KB, patch)
2014-08-15 23:29 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12180 - Remove HTML from batchMod.pl (9.86 KB, patch)
2014-08-16 08:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-05-04 17:18:11 UTC
There is HTML code on batchMod.pl
In particular an untranslatable "Tag Editor"
Comment 1 Bernardo Gonzalez Kriegel 2014-05-04 17:28:21 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-05-04 17:33:50 UTC Comment hidden (obsolete)
Comment 3 Srdjan Jankovic 2014-08-15 01:44:32 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-08-15 21:02:04 UTC
The Javascript on the page is broken before and after the patch (bug 12777):(

But I also found a regression: without the patch the date accessioned plugin works ok, but with the patch, it doesn't populate the field with the current date.
Comment 5 Bernardo Gonzalez Kriegel 2014-08-15 23:29:36 UTC Comment hidden (obsolete)
Comment 6 Bernardo Gonzalez Kriegel 2014-08-16 00:03:01 UTC
(In reply to Katrin Fischer from comment #4)
> The Javascript on the page is broken before and after the patch (bug 12777):(

I left a note on that bug... problem is that later i found it :(
But really can't reproduce. If I clean browser cache it disappears.

> But I also found a regression: without the patch the date accessioned plugin
> works ok, but with the patch, it doesn't populate the field with the current
> date.

Great QA :)

Fixed, was one line, simple fix. 
I left status as signed, unless you think differently.
Comment 7 Katrin Fischer 2014-08-16 08:17:36 UTC
Created attachment 30871 [details] [review]
[PASSED QA] Bug 12180 - Remove HTML from batchMod.pl

This patch removes HTML code from batchMod.pl

To test:
1. Check no regressions on batchMod editor,
Go to Tools > Batch item modification,
put a know barcode on barcode list, press continue

2. Check new line on translation files, update
a language, look for 'Tag editor'

Fixed capitalisation

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>

Amended patch, a stupid mistake on line 198 of batchMod-edit.tt

-                    [% javascript %]
+                    [% mv.javascript %]

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Passes tests and QA script.
Comment 8 Tomás Cohen Arazi 2014-08-19 12:36:58 UTC
Patch pushed to master.

Thanks Bernardo!