Bug 12314 - "Pay an amount toward all fines" does not save the note
Summary: "Pay an amount toward all fines" does not save the note
Status: RESOLVED DUPLICATE of bug 12865
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-27 05:36 UTC by paxed
Modified: 2014-10-08 14:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-05-27 05:36:18 UTC 
Pay Fines -> Pay amount, the note is not saved anywhere.
Comment 1 paxed 2014-05-27 06:49:41 UTC 
Looks like in paycollect.pl, $select is "", so recordpayment_selectaccts() is never called, instead recordpayment() is used. And that doesn't save any user-supplied note.

I added a quick hack to populate $select:

if (!$select) {
    my @tmp = ();
    for (my $i = 0; $i < $numaccts; $i++) {
        push(@tmp, $accts->[$i]->{'accountlines_id'}) if ($accts->[$i]->{'amountoutstanding'} > 0);
    }
    $select = join(",", @tmp);
}
Comment 2 Olli-Antti Kivilahti 2014-10-08 14:18:34 UTC 

*** This bug has been marked as a duplicate of bug 12865 ***