After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. Sould we create the file in bootstrap theme or set the syspref empty by default ?
I vote to set it empty by default. colors.css in the prog theme is an empty file, so it doesn't really do the prog theme any good to have opaccolorstylesheet filled automatically. The only theme which requires it is CCSR.
Created attachment 28669 [details] [review] Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error
Created attachment 28692 [details] [review] Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error Signed-off-by: David Cook <dcook@prosentient.com.au> Glad to see this one. That warning was annoying.
Created attachment 28699 [details] [review] Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks Fridolin!
Pushed to 3.16.x for inclusion in 3.16.2.