Bug 12456 - The file C4/Maintainance.pm can be removed
Summary: The file C4/Maintainance.pm can be removed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Yohann Dufour
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-20 09:20 UTC by Yohann Dufour
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12456: The file C4/Maintainance.pm, and by extension the file t/Maintainance.t, has been removed (6.73 KB, patch)
2014-06-20 09:25 UTC, Yohann Dufour
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12456: The file C4/Maintainance.pm, and by extension the file t/Maintainance.t, has been removed (6.88 KB, patch)
2014-06-20 20:08 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12456: The file C4/Maintainance.pm, and by extension the file t/Maintainance.t, has been removed (6.94 KB, patch)
2014-06-21 15:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Yohann Dufour 2014-06-20 09:20:14 UTC
With the command : git grep C4::Maintainance , we can see that the module is used nowhere. So, the files C4/Maintainance.pm, and by extension t/Maintainance.t, are useless, they can be removed.
Comment 1 Yohann Dufour 2014-06-20 09:25:42 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-06-20 20:08:58 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-21 15:27:50 UTC
But a functionality that would be nice to have again... being able to undo deletes of items and bilbios... :)
Comment 4 Katrin Fischer 2014-06-21 15:32:02 UTC
Created attachment 29129 [details] [review]
[PASSED QA] Bug 12456: The file C4/Maintainance.pm, and by extension the file t/Maintainance.t, has been removed

The file C4/Maintainance.pm is not used anywhere, it can be removed, and by extension, the file t/Maintainance.t too.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
A relic from the past :)
No references to this file or it's subs
No errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2014-07-02 18:18:29 UTC
Patch pushed to master.

Thanks Yohann!
Comment 6 Galen Charlton 2014-07-23 21:32:54 UTC
Pushed to 3.16.x for inclusion in 3.16.2.