12610 – Replace use of DBI in C4::Tags with DBIx::Class

Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class

Summary: Replace use of DBI in C4::Tags with DBIx::Class

Status:	CLOSED WONTFIX

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Galen Charlton
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:	12608
	Show dependency tree / graph

Reported:	2014-07-18 16:38 UTC by Kyle M Hall (khall)
Modified:	2017-06-14 22:10 UTC (History)
CC List:	1 user (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class (14.62 KB, patch) 2014-07-18 16:39 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class (14.59 KB, patch) 2014-07-18 16:46 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class (14.59 KB, patch) 2014-07-18 16:51 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class (14.84 KB, patch) 2014-07-18 17:05 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kyle M Hall (khall) 2014-07-18 16:38:00 UTC

We should replace the use of DBI in C4::Tags with DBIC instead.

Comment 1 Kyle M Hall (khall) 2014-07-18 16:39:17 UTC Comment hidden (obsolete)

Created attachment 29860 [details] [review]
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Tags.t
3) Note all unit tests pass

Comment 2 Kyle M Hall (khall) 2014-07-18 16:46:09 UTC Comment hidden (obsolete)

Created attachment 29861 [details] [review]
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Tags.t
3) Note all unit tests pass

Comment 3 Kyle M Hall (khall) 2014-07-18 16:51:06 UTC Comment hidden (obsolete)

Created attachment 29862 [details] [review]
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Tags.t
3) Note all unit tests pass

Comment 4 Kyle M Hall (khall) 2014-07-18 17:05:01 UTC

Created attachment 29863 [details] [review]
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Tags.t
3) Note all unit tests pass

Comment 5 Jonathan Druart 2014-08-29 14:05:43 UTC

(In reply to Kyle M Hall from comment #4)

> 3) Note all unit tests pass

It would have work if t/db_dependent/Tags.t covered all subroutines from C4::Tags.
It is not the case at all, only stratify_tags is covered.
Would it be possible to add some unit tests to this file to prove all your changes don't introduce regression?

Comment 6 Kyle M Hall (khall) 2016-08-23 16:44:11 UTC

I don't have time to continue working on this patch.