Bug 12614 - Remove CGI::scrolling_list from auth_subfields_structure.pl
Summary: Remove CGI::scrolling_list from auth_subfields_structure.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 766
  Show dependency treegraph
 
Reported: 2014-07-19 23:57 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl (14.05 KB, patch)
2014-07-20 01:30 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl (14.18 KB, patch)
2014-07-25 15:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl (14.45 KB, patch)
2014-07-28 21:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-07-19 23:57:59 UTC
Many to remove in this file
Comment 1 Bernardo Gonzalez Kriegel 2014-07-20 01:30:24 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-07-25 15:13:23 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-07-28 21:10:23 UTC
Created attachment 30234 [details] [review]
[PASSED QA] Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl

This patch removes all instances on this file. Even removes some commented out instances.

Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed.
Up to QA or RM for consideration, simply to remove.
But is strange to have a non editable field on auth frameworks.

To test:
1. Apply the patch
2. Go to Administration > Authority types
3. Clic MARC structure of any auth fw
4. Clic subfield on any tag, e.g. 031
5. Clic 'Edit subfields' button

Now the tests proper

6. 'Help input' box (editor bottom):
Eight(8) scrolling_list removed, they use to
feed the four pulldowns, so check each one
'Koha field' is new (for me at last)
'Authorised value',
'Thesaurus' (is this valid/useful here?)
'Plugin'
There is a difference between existing subtags and a new subtag,
the 'id' of the pulldowns (so the 8 scrolling list removed)
Check assign/remove/save/load values, search for regressions
If you edit subtag 942, it has a value on kohafield (default fw)

I think that this box could be prettified with fixed width for
pulldowns.

7. No more functional tests, there are 4 scrolling_list removed
that are commented (removed also commented code on tt file),
and two instances that are similar to previously removed
instances, evidently with no effect.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Not sure about the new Koha field entry... All works as expected.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All works as expected.
About Koha field: I think it makes sense to have it in the form,
so you can configure the fields for new authority types.
In my database I have mappings on authtypecode and authid.
Comment 4 Tomás Cohen Arazi 2014-07-29 14:49:45 UTC
Patch pushed to master.

Thanks Bernardo!