Bug 12646 - Only "top 20" rows visible in invoices search result
Summary: Only "top 20" rows visible in invoices search result
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 12761 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-24 08:54 UTC by Jacek Ablewicz
Modified: 2015-07-15 11:01 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12646: Display all invoices on the same page (1.25 KB, patch)
2014-08-19 08:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12646: Display all invoices on the same page (1.34 KB, patch)
2014-09-24 16:22 UTC, Paola Rossi
Details | Diff | Splinter Review
[PASSED QA] Bug 12646: Display all invoices on the same page (1.36 KB, patch)
2014-10-03 14:54 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Ablewicz 2014-07-24 08:54:38 UTC
Table rows visibility in invoice search results (acqui/invoices.pl) is limited to "top 20" table rows after Bug 12147 has been pushed.
Comment 1 Jonathan Druart 2014-07-24 09:05:00 UTC
Are you sure it is caused by bug 12147?
The patch removed "bPaginate: false,", so the pagination was already removed.
Comment 2 Jacek Ablewicz 2014-07-24 10:11:02 UTC
(In reply to Jonathan Druart from comment #1)
> Are you sure it is caused by bug 12147?
> The patch removed "bPaginate: false,", so the pagination was already removed.

Pretty sure that it was caused by removing "bPaginate: false," (or, at least, that after re-adding it, things seem to be back to normal). I don't really know why it works that way, some DataTables weirdness maybe? My guess is that with all DataTables controls hidden with "sDom: t", pagination in still in efect "under the hood" (but no longer controllable in any way: no way to navigate to next result page or control the amount displayed).

Anyway, it got me thinkig about the ergonomics of invoice search in general; maybe reenabling (at least some) datatables controls (instead of turning off "under the hood" pagination like in Bug 11798) would be way better aproach here? I mean, in mid-sized library, there may be hundreds/tousends invoices entered each year; after a relativelly short period of time this page would become less and less usable in it's current form (and also slower - but thats not easy remediable, unless we decide to convert it to ajax/server-side datatable variant ?).

Apart from pagination controlls, IMO it would be nice to have a general purpose datatables search box/filter available in this page. Doing some testing right now (with sDom: "t" simply removed):
- filtering by "show only subscription" does seem to coexist nicely with general-pupose DT search box (btw, having such a checkbox to show only open invoices would also be a great addition from an ergonomics standpoint)
- checkboxes for selecting invoices to be merged are beahving a little weird (invoices to be merged need to be selected on the same result page for the selection to become effecive); no idea how to fix it..
Comment 3 Jonathan Druart 2014-08-19 08:15:51 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-08-19 08:17:47 UTC
(In reply to Jacek Ablewicz from comment #2)
I totally agree with all what you told about the invoices page.
The patch I proposed only fix the pagination issue, I don't have enough time to provide a server-side version :)
Comment 5 Paola Rossi 2014-09-24 16:22:10 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2014-10-03 14:54:26 UTC
Created attachment 31991 [details] [review]
[PASSED QA] Bug 12646: Display all invoices on the same page

Only first 20 invoices were displayed on the page. Without pagination, DT
did not allow to show others.
This page explicitely removes the pagination option in order to display
all invoices on the page.

Test plan:
1/ Create 21+ invoices
2/ Go on acqui/invoices
3/ Verify all invoices are displayed.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2014-10-16 15:53:14 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 8 Jonathan Druart 2015-07-15 11:01:59 UTC
*** Bug 12761 has been marked as a duplicate of this bug. ***