Bug 12774 - Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices!
Summary: Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST...
Status: RESOLVED DUPLICATE of bug 12922
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 15:12 UTC by Kyle M Hall
Modified: 2015-01-02 13:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12774 - Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! (1.88 KB, patch)
2014-12-17 12:46 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-08-15 15:12:24 UTC

    
Comment 1 Kyle M Hall 2014-08-15 15:22:32 UTC
If talking tech is enabled, and a patron has selected phone notices for predue and/or due notices, advance_notices will die when coming upon a patron with phone notices selected. The TT script for advance notices does not use a letter and thus no letter exists for it by default. When advance_notices comes upone this, it sees the phone transport, tries to get the notices for the phone transport, and dies.

Resolutions:
1) Strip 'phone' from the list of transports in advance_notices.pl
2) Change the die at line 376 to a warn or carp. There is no reason not to allow the script to continue sending notices.
Comment 2 Katrin Fischer 2014-11-01 06:32:49 UTC
I suspect this could be a duplicate of bug 12730
Comment 3 Kyle M Hall 2014-12-17 12:46:33 UTC
Created attachment 34481 [details] [review]
Bug 12774 - Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices!

If talking tech is enabled, and a patron has selected phone notices for
predue and/or due notices, advance_notices will die when coming upon a
patron with phone notices selected. The TT script for advance notices
does not use a letter and thus no letter exists for it by default. When
advance_notices comes upone this, it sees the phone transport, tries to
get the notices for the phone transport, and dies.

Test Plan:
1) Enable TalkingTech
2) Set one or more patrons to recieve advance notices via phone
3) Set one or more patrons so they should recieve an advance notice today
4) Run advance_notices.pl, note that it dies
5) Apply this patch
6) Run advance_notices.pl, note that it now warns instead of dying
Comment 4 Jonathan Druart 2015-01-02 13:59:28 UTC
Kyle,
I prefer the patch proposed on bug 12922.
It does the same thing but at one other place.

*** This bug has been marked as a duplicate of bug 12922 ***