This was managed in bug 5342. For a better readability, I moved it in its own bug.
Created attachment 31278 [details] [review] Bug 12852: The "preview" param can be removed serials/claims.pl This case (preview=1) never appened. This patch remove all occurrences in the pl and the tt files. Test plan: Verify you don't manage to find a place where preview is set to 1 on the claim serials page.
Created attachment 31489 [details] [review] Bug 12852: Some unused stuffs more These parameters are never used. GetBookSeller takes a string (bookseller name) in parameter, not an id!
Created attachment 31831 [details] [review] Bug 12852: C4::Bookseller should not be imported anymore This script does not depend on C4::Bookseller anymore. The import can be removed.
Created attachment 31838 [details] [review] Bug 12852: The "preview" param can be removed serials/claims.pl I've applied the patch against master 3.17.00.025 Firstly I've applied 5342. Everything is OK. So I pass the patch to "Signed Off" status.
Created attachment 31839 [details] [review] Bug 12852: Some unused stuffs more
Created attachment 31840 [details] [review] Bug 12852: C4::Bookseller should not be imported anymore
Created attachment 32275 [details] [review] [PASSED QA] Bug 12852: The "preview" param can be removed serials/claims.pl This case (preview=1) never appened. This patch remove all occurrences in the pl and the tt files. Test plan: Verify you don't manage to find a place where preview is set to 1 on the claim serials page. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 32276 [details] [review] [PASSED QA] Bug 12852: Some unused stuffs more These parameters are never used. GetBookSeller takes a string (bookseller name) in parameter, not an id! Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 32277 [details] [review] [PASSED QA] Bug 12852: C4::Bookseller should not be imported anymore This script does not depend on C4::Bookseller anymore. The import can be removed. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.01