Bug 12953 - Bug 12827 causes a test to fail
Summary: Bug 12827 causes a test to fail
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Galen Charlton
URL:
Keywords:
Depends on: 10402 12827
Blocks: 12830
  Show dependency treegraph
 
Reported: 2014-09-18 07:41 UTC by Jonathan Druart
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12953: FIX NewOrder test (949 bytes, patch)
2014-09-18 07:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12953: FIX NewOrder test (1.02 KB, patch)
2014-09-18 09:39 UTC, Paola Rossi
Details | Diff | Splinter Review
[PASSED QA] Bug 12953: FIX NewOrder test (1.05 KB, patch)
2014-09-18 13:06 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-09-18 07:41:39 UTC
The patch for bug 12827 has been written some days before bug 10402. One occurrence of NewOrder has not been modified.

To reproduce: prove t/db_dependent/Letters.t

fails: t/db_dependent/Letters.t .. 2/58 DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 9 at C4/Letters.pm line 322.
Comment 1 Jonathan Druart 2014-09-18 07:43:28 UTC Comment hidden (obsolete)
Comment 2 Paola Rossi 2014-09-18 09:39:48 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-09-18 13:06:21 UTC
Created attachment 31713 [details] [review]
[PASSED QA] Bug 12953: FIX NewOrder test

The patch for bug 12827 has been written some days before bug 10402. One
occurrence of NewOrder has not been modified.

Test plan:
  prove t/db_dependent/Letters.t

should return green.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2014-09-18 13:11:38 UTC
Patch pushed to master.

Thanks Jonathan for the quick fix!