Bug 13087 - Add a notice for use_zebra_facets problems in about page
Summary: Add a notice for use_zebra_facets problems in about page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on: 11232
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-15 16:06 UTC by Tomás Cohen Arazi
Modified: 2015-06-04 23:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13087: Add a notice for use_zebra_facets problems in about page (3.22 KB, patch)
2014-10-22 19:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 13087: Add a notice for use_zebra_facets problems in about page (3.36 KB, patch)
2014-10-23 15:05 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 13087: Add a notice for use_zebra_facets problems in about page (3.48 KB, patch)
2014-10-24 05:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2014-10-15 16:06:00 UTC
11232 introduced the use of Zebra facets. A way of telling the user that a conflicting configuration is set needs to be added to the about page.
Comment 1 Tomás Cohen Arazi 2014-10-22 19:08:13 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-10-23 15:05:39 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-24 05:42:57 UTC
Created attachment 32652 [details] [review]
[PASSED QA] Bug 13087: Add a notice for use_zebra_facets problems in about page

This patch adds two checks to about.pl:

- use_zebra_facets entry presence in koha-conf.xml
- use_zebra_facets==1 and zebra_bib_index_mode==dom

The idea is to alert the user if it has conflicting or wrong settings. Even
if there's a fallback to a working configuration.

To test:
- On clean master install, go to the about page
=> SUCCESS: No warnings regarding use_zebra_facets
- Comment out the use_zebra_facets entry, reload
=> SUCCESS: The about page mentions the use_zebra_facets entry is missing
- Uncomment the use_zebra_facets entry, make sure it is set to 1
- Change zebra_bib_index_mode to 'grs1', reload
=> SUCCESS: The about page says zebra_bib_index_mode is not set to DOM even though
  you have use_zebra_facets set.
- Sign off :-D

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Followed test plan with success

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, tested by changing the koha-conf.xml file.
Note: There is no warning if use_zebra_facets is 0.
Comment 4 Tomás Cohen Arazi 2014-10-24 13:04:15 UTC
Patch pushed to master.