Bug 13113 - Prevent juvenile/children from reserving ageRestricted material
Summary: Prevent juvenile/children from reserving ageRestricted material
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on: 13106
Blocks: 11999 13116 18045
  Show dependency treegraph
 
Reported: 2014-10-20 12:53 UTC by Olli-Antti Kivilahti
Modified: 2017-05-17 07:17 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13113 - Prevent juvenile/children from reserving ageRestricted material (5.07 KB, patch)
2014-10-20 14:51 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13113 - Prevent juvenile/children from reserving ageRestricted material (6.89 KB, patch)
2014-10-21 11:47 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13113 - Prevent juvenile/children from reserving ageRestricted material (6.89 KB, patch)
2014-10-23 13:08 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13113 - Prevent juvenile/children from reserving ageRestricted material (5.14 KB, patch)
2014-10-23 14:46 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13113 - Prevent juvenile/children from reserving ageRestricted material (4.87 KB, patch)
2014-10-24 09:38 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13113 - Prevent juvenile/children from reserving ageRestricted material (5.13 KB, patch)
2014-10-29 13:34 UTC, Marc Véron
Details | Diff | Splinter Review
32915: Bug 13113 - Prevent juvenile/children from reserving ageRestricted material (5.20 KB, patch)
2014-10-31 14:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13113 [QA Followup] - Fix unit test (1.46 KB, patch)
2014-10-31 14:11 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2014-10-20 12:53:48 UTC
There is no reason for underage borrowers to reserve ageRestricted material and then be denied it's check-out due to ageRestriction.

This patch prevents reserving material for borrowers not suitably aged.

 # # # # # # # # # # #
# REPLICATE THIS ISSUE #
 # # # # # # # # # # #
1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16".
2. Get a Borrower who is younger than 16 years.
3. Place a hold for the underage Borrower for the ageRestricted Record.
4. You can reserve an ageRestricted Record with ease.
5. Check-in an Item from the ageRestricted Record and catch the reservation.
6. Check-out the ageRestricted Item for this underage Borrower.
7. You get a notification about being unable to check-out due to age restriction. How lame is that for a 12 year old?

 # # # # # # # # #
# AFTER THE PATCH #
 # # # # # # # # #
1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16".
2. Get a Borrower who is younger than 16 years.
3. Check-out an ageRestricted Item for this underage Borrower.
4. You get a notification about beign unable to check-out due to age restriction.
5. Place a hold for the underage Borrower for the ageRestricted Record.
6. You get a notification, that placing a hold on ageRestricted material is forbidden.
Comment 1 Olli-Antti Kivilahti 2014-10-20 14:51:29 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-10-20 18:30:47 UTC
Should status be "Needs Signoff?
Comment 3 Olli-Antti Kivilahti 2014-10-21 11:47:57 UTC Comment hidden (obsolete)
Comment 4 Olli-Antti Kivilahti 2014-10-23 13:08:17 UTC Comment hidden (obsolete)
Comment 5 Olli-Antti Kivilahti 2014-10-23 14:46:06 UTC Comment hidden (obsolete)
Comment 6 Olli-Antti Kivilahti 2014-10-24 09:38:35 UTC Comment hidden (obsolete)
Comment 7 Olli-Antti Kivilahti 2014-10-24 15:03:21 UTC
Hi!

Just pushed this featureset to production, so I am rather confident about this :)

Have fun!
Comment 8 Chris Cormack 2014-10-25 03:41:05 UTC
Just a note, to test this you will need to make sure you have biblioitems.agerestriction mapped to a tag in your framework, or the tests will die.
Comment 9 Marc Véron 2014-10-29 13:34:05 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall 2014-10-31 14:10:49 UTC
Created attachment 33071 [details] [review]
32915: Bug 13113 - Prevent juvenile/children from reserving ageRestricted material
Comment 11 Kyle M Hall 2014-10-31 14:11:21 UTC
Created attachment 33072 [details] [review]
Bug 13113 [QA Followup] - Fix unit test
Comment 12 Tomás Cohen Arazi 2014-11-11 12:57:06 UTC
Patches pushed to master.

Thanks Olli!