Bug 13157 - Fix holdingbranch facet for UNIMARC
Summary: Fix holdingbranch facet for UNIMARC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Frédéric Demians
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-28 23:01 UTC by Mathieu Saby
Modified: 2015-06-04 23:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b (860 bytes, patch)
2014-11-02 16:55 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b (2.37 KB, patch)
2014-11-02 20:29 UTC, Frédéric Demians
Details | Diff | Splinter Review
[SIGNED OFF] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b (2.44 KB, patch)
2014-11-23 13:38 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED OFF] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks (2.35 KB, patch)
2014-11-23 13:38 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[PASSED QA] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b (2.50 KB, patch)
2014-11-24 20:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks (2.40 KB, patch)
2014-11-24 20:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2014-10-28 23:01:53 UTC
The new code for facets calculation could probably be more precise for unimarc (in biblio-koha-indexdefs.xml)


- for series, 410 tag is probably better than 225
- the date and place subdivisions 6XX$y and 6XX$z could be indexed (in su-geo and su-chrono)
- the subdivisionn $x is indexed for 606, but all 6XX$x could also be indexed (in su-to)
- 5XX are not subjects, so I'm not sure that indexing them in su-ut is good (but we should check in ccl.properties how this index is defined). Anyway, I always found that indexing 5XX was a weird idea...


and there is maybe a mistake for 995$b - holdingbranch (should be 995$c)

M. Saby
Comment 1 Frédéric Demians 2014-11-02 16:55:18 UTC Comment hidden (obsolete)
Comment 2 Mathieu Saby 2014-11-02 19:10:52 UTC
Hello

A change is also needed in biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xml

Mathieu
Comment 3 Frédéric Demians 2014-11-02 20:29:52 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-11-23 07:34:10 UTC
Could soomeone give this a sign-off please?
Comment 5 Tomás Cohen Arazi 2014-11-23 13:31:52 UTC
I was about to sign it off, but comparing to the current frameworks I wasn't sure:

('995', 'a', 'Fournisseur', '', 0, 0, 'items.booksellerid', -1, '', '', '', 0, 0, '', NULL, '', ''),
('995', 'b', 'Site Propriétaire', '', 0, 1, 'items.homebranch', 10, 'branches',...
('995', 'c', 'Site Dépositaire', '', 0, 1, 'items.holdingbranch', 10, 'branches',...

So maybe a followup is needed too.
Comment 6 Tomás Cohen Arazi 2014-11-23 13:38:08 UTC Comment hidden (obsolete)
Comment 7 Tomás Cohen Arazi 2014-11-23 13:38:51 UTC Comment hidden (obsolete)
Comment 8 Tomás Cohen Arazi 2014-11-23 13:40:15 UTC
Please feel free to obsolete my followup if you think it is wrong. But in that case please check

installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql

and fill a new bug for it.
Comment 9 Frédéric Demians 2014-11-24 15:42:19 UTC
(In reply to Tomás Cohen Arazi from comment #8)
> Please feel free to obsolete my followup if you think it is wrong. But in
> that case please check
> 
> installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/
> framework_DEFAULT.sql
> 
> and fill a new bug for it.

No, your followup is correct! and required. Mine was incomplete.
Comment 10 Katrin Fischer 2014-11-24 20:43:10 UTC
Created attachment 33878 [details] [review]
[PASSED QA] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b

Fix a typo. Not test plan required, just a look at default UNIMARC framework.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2014-11-24 20:43:58 UTC
Created attachment 33879 [details] [review]
[PASSED QA] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Tomás Cohen Arazi 2014-11-25 18:36:53 UTC
Patches pushed to master.

Thanks Frederic!