Bug 13212 - Use CSS3 ellipsis instead of FacetLabelTruncationLength
Summary: Use CSS3 ellipsis instead of FacetLabelTruncationLength
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 08:08 UTC by paxed
Modified: 2020-11-30 21:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 13212 - Use CSS3 ellipsis instead of FacetLabelTruncationLength - intranet (2.33 KB, patch)
2015-04-02 08:45 UTC, Fridolin Somers 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-11-06 08:08:08 UTC 
CSS3 has text-overflow: ellipsis - should use that instead of FacetLabelTruncationLength
Comment 1 Fridolin Somers 2015-04-02 08:45:51 UTC 
Created attachment 37428 [details] [review]
Bug 13212 - Use CSS3 ellipsis instead of FacetLabelTruncationLength - intranet

CSS3 has text-overflow: ellipsis - should use that instead of FacetLabelTruncationLength.

This patch provides a POC for intranet.
It adds ellipsis on all facet types except the availability one.

Try to play with facets block size to see ellipsis is correct.

See that facet count is hidden when ellipsis is used.
An easy way to correct would be to set facet count first.
Comment 2 Fridolin Somers 2015-04-02 08:46:58 UTC 
This a POC to test on intranet facets.
Comment 3 Owen Leonard 2016-02-01 15:04:37 UTC 
This works, but I don't think it's the right place to use this CSS3 feature. I think it's important for libraries to be able to choose to display the full facet using FacetLabelTruncationLength if they want to, without resorting to custom CSS rules.
Comment 4 Katrin Fischer 2020-01-06 12:54:49 UTC 
(In reply to Owen Leonard from comment #3)
> This works, but I don't think it's the right place to use this CSS3 feature.
> I think it's important for libraries to be able to choose to display the
> full facet using FacetLabelTruncationLength if they want to, without
> resorting to custom CSS rules.

Agreed, marking WONTFIX for now.