Bug 13241 - Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected
Summary: Notice for account details ( ACCTDETAILS ) will only send in plain text even ...
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-12 12:23 UTC by Kyle M Hall
Modified: 2015-12-03 22:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13241 [3.16.x] - Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected (1.61 KB, patch)
2014-11-12 12:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13241 - Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected (2.27 KB, patch)
2014-11-12 12:30 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13241 - Change creation_time to created_on (5.70 KB, patch)
2014-12-19 16:39 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-11-12 12:23:33 UTC
The notice ACCTDETAILS will be sent to a new patron on creation if that account has an email address. This notice will always be send in plain text even if the html option is selected in the notice editor.
Comment 1 Kyle M Hall 2014-11-12 12:26:21 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-11-12 12:30:00 UTC
Created attachment 33481 [details] [review]
Bug 13241 - Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected

The notice ACCTDETAILS will be sent to a new patron on creation if that
account has an email address. This notice will always be send in plain
text even if the html option is selected in the notice editor.

Test Plan:
1) Create an ACCTDETAILS notice containing html, ensure that the
   "HTML message" box is checked.
2) Create a new patron with an email address you control
3) Read the email that is sent to you, notice it is in plain text
   with the html markup clearly visible
4) Apply this patch
5) Delete the patron, and re-create the patron again
6) Note that this time the HTML is parsed correctly
Comment 3 Marcel de Rooy 2014-11-12 13:31:58 UTC
Hi Kyle,
Just to let you know: Recently we had a discussion about this notice on another report. A majority wanted to get rid of this notice (for security reasons) instead of extending its use; i abandoned some development therefore.

Marcel
Comment 4 Kyle M Hall 2014-12-19 16:39:07 UTC Comment hidden (obsolete)
Comment 5 Paola Rossi 2015-02-25 14:51:15 UTC
I've applied the patch against master 3.19.00.012 head 13473.

On tools I've copied an ACCTDETAILS' notice to CPL, checking ON its "Html message" box as required.

I received a mail against a new patron.
The source of the message of the mail I received was exactly the same of the mail's source I received on master (f.e. still "text/plain").
If I asked to the email client to show the received mail as "HTML" or as "text" I saw no difference.

[Is there any notice which is OK about the "HTML message" option?]

I think this bug had not fixed the error.
So I pass the patch to "Failed QA" status.
Comment 6 Paola Rossi 2015-02-26 14:16:59 UTC
The problem has been fixed by Bug 12739, which is even a more wide solution.

So I pass the status of this bug to "RESOLVED/WORKSFORME".