Bug 13288 - Saved reports tabs broken by DataTables upgrade
Summary: Saved reports tabs broken by DataTables upgrade
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 12986
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-18 17:35 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13288: Fix filtering on the saved reports table (1.33 KB, patch)
2014-11-19 09:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 13288: Fix filtering on the saved reports table (1.42 KB, patch)
2014-11-19 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 13288: Fix filtering on the saved reports table (1.52 KB, patch)
2014-11-19 19:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-11-18 17:35:44 UTC
Bug 12986 (Upgrade the DataTables jQuery plugin to the latest version (1.10.2)) broke the saved reports tabs for "groups" like Accounts, Acquistitions, Catalog, etc. Clicking any tab other than "All" shows no reports.
Comment 1 Jonathan Druart 2014-11-19 09:16:42 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-11-19 09:17:00 UTC
I got it!
Comment 3 Owen Leonard 2014-11-19 17:30:05 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-11-19 19:53:29 UTC
Created attachment 33696 [details] [review]
[PASSED QA] Bug 13288: Fix filtering on the saved reports table

Since bug 12986 has been pushed, the tabs don't filter correctly the
table on the saved report list (reports/guided_reports.pl?phase=Use
saved

Test plan:
Go on Reports > Guided reports wizard > Saved reports
Verify the tabs work as expected.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed problem and that the patch fixes it, passes tests
and QA script.
Comment 5 Tomás Cohen Arazi 2014-11-20 12:58:49 UTC
Patch pushed to master.

Thanks Jonathan!