The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in.
Created attachment 33663 [details] [review] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red.
I suggest that when an item is successfully checked in the data in the "date due" column be updated too. Perhaps repeat "Returned" there? Or perhaps "Available?"
(In reply to Owen Leonard from comment #2) > I suggest that when an item is successfully checked in the data in the "date > due" column be updated too. Perhaps repeat "Returned" there? Or perhaps > "Available?" I like 'returned' since we can't be sure it's available.
Created attachment 33766 [details] [review] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red.
Updated patch to change the due date to "Returned". Patch now depends on bug 13286 which adds a span to each of the due dates in the checkouts table.
While this patch applies the highlighting to all items returned at the same time, it only changes the due date in the due date column on the last item in the list. The due date of all other items returned at the same time are left as due dates. Christopher
Created attachment 34119 [details] [review] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red.
Fixed! (In reply to Christopher Brannon from comment #6) > While this patch applies the highlighting to all items returned at the same > time, it only changes the due date in the due date column on the last item > in the list. The due date of all other items returned at the same time are > left as due dates. > > Christopher
Would like to see more specific reason for not being able to return, but that is for another ticket. Works as described. Nice work. Christopher
Created attachment 34130 [details] [review] [SIGNED OFF] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red. Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org>
Created attachment 34184 [details] [review] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red. Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Maybe a more explicit class name could have been chosen :)
The standard term in the default English templates is "checked in," not "returned."
While Owen is right about the convention to use the term "Checked in", we already display "Returned" at the end of the table. I think we should fix this, but separate from this patch.
Created attachment 34728 [details] [review] [PASSED QA] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red. Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Kyle!
Pushed to 3.18.x will be in 3.18.3
Pushed to 3.16.x, patch will be in 3.16.7