Untranslatable javascript in /koha-tmpl/intranet-tmpl/prog/en/members/members.tt line 243 "for patron", and line 225 "on " and "fields "
The file name is koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt The whole update_searched() javascript function should be redone with i18n in mind - using format() and %s placeholders instead of concatenating strings.
(In reply to paxed from comment #1) See Coding Guidelines at <http://wiki.koha-community.org/wiki/Coding_Guidelines#JS2:_Enabling_translation_of_language_strings_in_embedded_JavaScript> in JS2 Section. Maybe need to be wrapped to the special funciton _(). > The file name is koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt > > The whole update_searched() javascript function should be redone with i18n > in mind - using format() and %s placeholders instead of concatenating > strings.
To reproduce: Go to Home > Patrons (cgi-bin/koha/members/members-home.pl) - Switch language e.g. to German - Use filter and fill all fields You get a result like: Treffer gefunden for patron on standard fields beginnend mit Nepomuk mit Kategorie Erwachsener in der Bibliothek Allschwil Hmm, English version looks weird too: Results found for patron on borrower number fields starting with 1 with category Staff in library Fairview Something like the following would look better and would be better to translate: Patrons found for: Standard containing 'A' with category 'Adult' in library Airfield
Created attachment 36386 [details] [review] Bug 13351 - Untranslatable javascript in members.tt This patch streamlines the page title text for search results in Home > Patrons to make it translateable (and more readable). To test: - Apply patch - Select Englsh language - Apply filter wit several values or click on a letter for "Browse by last name" - Verify that the title makes sense - Translate to your language and select this language - Verify that the text appears properly in your language
Created attachment 36427 [details] [review] Bug 13351 - Untranslatable javascript in members.tt This patch streamlines the page title text for search results in Home > Patrons to make it translateable (and more readable). To test: - Apply patch - Select Englsh language - Apply filter wit several values or click on a letter for "Browse by last name" - Verify that the title makes sense - Translate to your language and select this language - Verify that the text appears properly in your language Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 36579 [details] [review] [PASSED QA] Bug 13351 - Untranslatable javascript in members.tt This patch streamlines the page title text for search results in Home > Patrons to make it translateable (and more readable). To test: - Apply patch - Select Englsh language - Apply filter wit several values or click on a letter for "Browse by last name" - Verify that the title makes sense - Translate to your language and select this language - Verify that the text appears properly in your language Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. http://bugs.koha-community.org/show_bug.cgi?id=13352
Pity the patch doesn't use the javascript .format() function, but just concatenates strings together. Bad sentence structures it makes.
Patch pushed to master. Thanks Marc!
Pushed to 3.18.x will be in 3.18.5