Bug 13435 - OPAC self registration can't find OPAC_REG_VERIFY notice if it is assigned to a branch
Summary: OPAC self registration can't find OPAC_REG_VERIFY notice if it is assigned to...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nicole C. Engard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-10 21:46 UTC by Liz Rea
Modified: 2017-06-14 22:11 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2014-12-10 21:46:16 UTC
Email verification can look very broken for multi branch systems - if there is no "all libraries" notice defined for "OPAC_REG_VERIFY," but one defined for a specific branch, the self registration code can't find the notice and thus the verification email is not sent.

Additionally, this code will only ever return the "all libraries" version of this notice, as it never passes a branchcode - making this notice useless on a per-branch basis.
Comment 1 Liz Rea 2015-08-02 21:32:59 UTC
While I was looking over my bugs in progress, it occurred to me that this can never work how we want it to, because we don't allow self registering borrowers to select their branch. Without a logged in user, Koha will never know which branch to send to the notices module, and thus it will never know which notice to use (except "All libraries").

So either we need a little re-engineering here, or at the very least documentation of why this doesn't/can't work the way libraries might expect.
Comment 2 Liz Rea 2015-11-05 22:13:08 UTC
Nicole would you make sure that we say something about this notice in the manual please?

Let me know if you need more explanation.
Comment 3 Nicole C. Engard 2016-07-20 15:47:05 UTC
We allow patrons to pick a branch now I believe - I'm sorry I didn't see this sooner :(