Email verification can look very broken for multi branch systems - if there is no "all libraries" notice defined for "OPAC_REG_VERIFY," but one defined for a specific branch, the self registration code can't find the notice and thus the verification email is not sent. Additionally, this code will only ever return the "all libraries" version of this notice, as it never passes a branchcode - making this notice useless on a per-branch basis.
While I was looking over my bugs in progress, it occurred to me that this can never work how we want it to, because we don't allow self registering borrowers to select their branch. Without a logged in user, Koha will never know which branch to send to the notices module, and thus it will never know which notice to use (except "All libraries"). So either we need a little re-engineering here, or at the very least documentation of why this doesn't/can't work the way libraries might expect.
Nicole would you make sure that we say something about this notice in the manual please? Let me know if you need more explanation.
We allow patrons to pick a branch now I believe - I'm sorry I didn't see this sooner :(