This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated!
Created attachment 34454 [details] [review] Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated!
Created attachment 34455 [details] [review] Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them.
Created attachment 34506 [details] [review] Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months.
Created attachment 34661 [details] [review] Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns instead of issues,weeks,months.
Created attachment 34765 [details] [review] Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns instead of issues,weeks,months. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Hi Olli-Antti, the problem in the bug description is a real one, but I am uncomfortable with the number of changes in this patch. The more changes, the more suspicious I get! I see like 3 different bugs here: 1) Translation problem, introduction of a new include - I think the include should be in the includes directory, starting with serials-... to match the existing includes. Pleaes fix. 2) STL is not saved correctly. - Problem seems to be fixed by this patch, but I want to test more for side effects of the variable changes after a follow-up. 3) Changes to serials/subscription-numberpatterns.pl/tt - I don't understand why those have been made - maybe it's too late tonight. Please include an explanation and amend test plan.
> We make an subscription with SLT of months = 12. > Later make an arbitrary edit to the subscription, and miss out the fact that > the SLT selection is set to issues. > Save the changes. > Serial subscription end date is set to 12 issues since the start date, > instead of 12 months which it used to be. This causes a myriad of issues :=) > > AFTER THIS PATCH: > > SLT defaults to the value initially saved instead of always being issues. > Now the selection can be translated! This has been fixed by bug 14022 now - as this patch includes some more changes, I am not closing it yet.
(In reply to Olli-Antti Kivilahti from comment #0) > This issue causes loss of data when the subscription length type (SLT) is > other than issues. > > TO REPLICATE: > > We make an subscription with SLT of months = 12. > Later make an arbitrary edit to the subscription, and miss out the fact that > the SLT selection is set to issues. > Save the changes. > Serial subscription end date is set to 12 issues since the start date, > instead of 12 months which it used to be. This causes a myriad of issues :=) > > AFTER THIS PATCH: > > SLT defaults to the value initially saved instead of always being issues. > Now the selection can be translated! I just re-tested ths and the subscription length settings remain unchanged when editing a subscription now.