Bug 13532 - Unit test for Bug 13261
Summary: Unit test for Bug 13261
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-07 15:00 UTC by Olli-Antti Kivilahti
Modified: 2015-05-09 16:37 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13532 - Unit test for Bugg 13261 (6.69 KB, patch)
2015-01-07 15:02 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13532 - Unit test for Bugg 13261 (6.58 KB, patch)
2015-01-07 15:04 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13532 - Unit test for Bugg 13261 (7.25 KB, patch)
2015-01-07 15:50 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13532 - Unit tests for Bugg 13261 (7.72 KB, patch)
2015-01-08 12:29 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 13532 - Unit tests for Bugg 13261 (7.65 KB, patch)
2015-05-09 16:33 UTC, M. Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2015-01-07 15:00:44 UTC
This patch adds a unit test to check against timeout of:
checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server.
This is because creating a new DateTime for year 9999 takes forever.
Comment 1 Olli-Antti Kivilahti 2015-01-07 15:02:28 UTC Comment hidden (obsolete)
Comment 2 Olli-Antti Kivilahti 2015-01-07 15:04:06 UTC Comment hidden (obsolete)
Comment 3 Olli-Antti Kivilahti 2015-01-07 15:50:25 UTC Comment hidden (obsolete)
Comment 4 Olli-Antti Kivilahti 2015-01-08 12:29:10 UTC Comment hidden (obsolete)
Comment 6 Bernardo Gonzalez Kriegel 2015-05-07 16:55:21 UTC
CONFLICT (content): Merge conflict in t/db_dependent/SIP_ILS.t
Failed to merge in the changes.
Patch failed at 0001 Bug 13532 - Unit tests for Bugg 13261
Comment 7 M. Tompsett 2015-05-09 16:33:07 UTC
Created attachment 39007 [details] [review]
Bug 13532 - Unit tests for Bugg 13261

This patch adds unit tests to check against timeout of:
checking in an Item from a debarred borrower
  (a borrower whose koha.borrowers.debarred-column has year 9999)
timeouts the SIP-server.
This is because creating a new DateTime for year 9999 takes forever.
Comment 8 M. Tompsett 2015-05-09 16:35:34 UTC
Comment on attachment 39007 [details] [review]
Bug 13532 - Unit tests for Bugg 13261

Review of attachment 39007 [details] [review]:
-----------------------------------------------------------------

::: t/db_dependent/SIP_ILS.t
@@ +1,1 @@
> +#!/usr/bin/perl -d

Why -d?

@@ +15,4 @@
>  
>  BEGIN {
>          use_ok('C4::SIP::ILS');
> +        new C4::Context;

Why new?

@@ +22,5 @@
> +use Koha::Borrower::Debarments;
> +use C4::Circulation;
> +use C4::Biblio;
> +use C4::Items;
> +use Sip;

What is Sip?
Comment 9 M. Tompsett 2015-05-09 16:37:06 UTC
Testing shouldn't require the user to type stuff, so there is something not quite right with this. Also, what is Sip? C4::SIP::Sip? I'm just going to Failed QA this, because it doesn't just work.