This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever.
Created attachment 35018 [details] [review] Bug 13532 - Unit test for Bugg 13261 This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever.
Created attachment 35019 [details] [review] Bug 13532 - Unit test for Bugg 13261 This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever.
Created attachment 35021 [details] [review] Bug 13532 - Unit test for Bugg 13261 This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever.
Created attachment 35036 [details] [review] Bug 13532 - Unit tests for Bugg 13261 This patch adds unit tests to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever.
patch doesn't apply, probably due to bug 7904: https://github.com/Koha-Community/Koha/commit/e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac#diff-4a1e76b1dab1bba0924ef5abb699ccfa
CONFLICT (content): Merge conflict in t/db_dependent/SIP_ILS.t Failed to merge in the changes. Patch failed at 0001 Bug 13532 - Unit tests for Bugg 13261
Created attachment 39007 [details] [review] Bug 13532 - Unit tests for Bugg 13261 This patch adds unit tests to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever.
Comment on attachment 39007 [details] [review] Bug 13532 - Unit tests for Bugg 13261 Review of attachment 39007 [details] [review]: ----------------------------------------------------------------- ::: t/db_dependent/SIP_ILS.t @@ +1,1 @@ > +#!/usr/bin/perl -d Why -d? @@ +15,4 @@ > > BEGIN { > use_ok('C4::SIP::ILS'); > + new C4::Context; Why new? @@ +22,5 @@ > +use Koha::Borrower::Debarments; > +use C4::Circulation; > +use C4::Biblio; > +use C4::Items; > +use Sip; What is Sip?
Testing shouldn't require the user to type stuff, so there is something not quite right with this. Also, what is Sip? C4::SIP::Sip? I'm just going to Failed QA this, because it doesn't just work.
Should we close this one?