Since bug 11944, the facets are not correctly encoded if the indexing mode is GRS1.
Created attachment 35634 [details] [review] Bug 13646: Fix facets encoding problem for GSR1 Since bug 11944, the facets are not correctly encoded if the indexing mode is GRS1. In MARC::File::USMARC # if utf8 the we encode the string as utf8 if ( $marc->encoding() eq 'UTF-8' ) { $tagdata = marc_to_utf8( $tagdata ); } $marc->encoding return 'MARC8' because the utf8 flag is not set on the marc record. Test plan: On an installation set with GRS1, launch a search and verify you have facets correctly encoded.
I thought that we'd officially deprecated GRS1 and that it was scheduled for removal?
Hello David, I found this bug because we have backported bug 11944 on 3.18.x for a customer. I thought this patch would be useful to someone else, that why I submitted it here. I don't mind if it is not pushed to master, but since it's a fix for bug 11944, it could be helpful to have it, for the record.
What is the purpose of the line : $mr; ?
To assign $mr to $marc_record.
Created attachment 35880 [details] [review] [SIGNED OFF] Bug 13646: Fix facets encoding problem for GSR1 Since bug 11944, the facets are not correctly encoded if the indexing mode is GRS1. In MARC::File::USMARC # if utf8 the we encode the string as utf8 if ( $marc->encoding() eq 'UTF-8' ) { $tagdata = marc_to_utf8( $tagdata ); } $marc->encoding return 'MARC8' because the utf8 flag is not set on the marc record. Test plan: On an installation set with GRS1, launch a search and verify you have facets correctly encoded. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Any reason why this is still listed as »needs signoff«? Tomas: did you just forget to change the status?
(In reply to Mirko Tietgen from comment #7) > Any reason why this is still listed as »needs signoff«? > > Tomas: did you just forget to change the status? I did, I'm sorry.
Testing this with Jonathan we located another problem with how the links are build - switching this to "Failed QA" waiting for a follow up or new patch.
Jonathan, is this still needed with the other patches to fix the encoding problems?
No idea, but GRS1 is now deprecated.