Sometimes the libraries will keep items ready for a patron to use on-site for a longer time than a day. It would be good if the feature allowed the library to optionally specify another due date for on-site checkouts. Currently the due date will always default to the end of the current day.
After checking with Jonathan, it would be ok to have the library always select the due date and not force it to the end of the day. I will try to make that happen.
*** Bug 13558 has been marked as a duplicate of this bug. ***
Created attachment 36659 [details] [review] Bug 13647: On-site checkouts - Allow library to specify due date This will remove the restriction that forces the due date for an on-site checkout to the end of the current day. It will still suggest the end of the day, but you will be able to change the date to whatever you want using the datepicker widget. To test: Before applying the patch: - Turn on OnSiteCheckouts and OnSiteCheckoutsForce system preferences - Check the on-site use checkbox and try to set due date manually, it should not be possible - Check out the item and check the due date is set to the end of today - Put a restriction on your patron account and repeat steps, the item checked out should again have a due date at the end of the day > There should be no way to be able to check out an item with a 'custom' due date Apply the patch: - Repeat steps from above, check out - on-site use without a restriction on your account - without changing the due date - with a due date picked with the datepicker - on-site use with a restriction on your account ... see above - no on-site use but with a specified due date - no on-site use, not specifying a due date
Created attachment 36666 [details] [review] Bug 13647: On-site checkouts - Allow library to specify due date This will remove the restriction that forces the due date for an on-site checkout to the end of the current day. It will still suggest the end of the day, but you will be able to change the date to whatever you want using the datepicker widget. To test: Before applying the patch: - Turn on OnSiteCheckouts and OnSiteCheckoutsForce system preferences - Check the on-site use checkbox and try to set due date manually, it should not be possible - Check out the item and check the due date is set to the end of today - Put a restriction on your patron account and repeat steps, the item checked out should again have a due date at the end of the day > There should be no way to be able to check out an item with a 'custom' due date Apply the patch: - Repeat steps from above, check out - on-site use without a restriction on your account - without changing the due date - with a due date picked with the datepicker - on-site use with a restriction on your account ... see above - no on-site use but with a specified due date - no on-site use, not specifying a due date Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Sorry, I found a bug. If SpecifyDueDate is disabled, the due date should be set to today.
Created attachment 36686 [details] [review] Bug 13647: On-site checkouts - Allow library to specify due date This will remove the restriction that forces the due date for an on-site checkout to the end of the current day. It will still suggest the end of the day, but you will be able to change the date to whatever you want using the datepicker widget. To test: Before applying the patch: - Turn on OnSiteCheckouts and OnSiteCheckoutsForce system preferences - Check the on-site use checkbox and try to set due date manually, it should not be possible - Check out the item and check the due date is set to the end of today - Put a restriction on your patron account and repeat steps, the item checked out should again have a due date at the end of the day > There should be no way to be able to check out an item with a 'custom' due date Apply the patch: - Repeat steps from above, check out - on-site use without a restriction on your account - without changing the due date - with a due date picked with the datepicker - on-site use with a restriction on your account ... see above - no on-site use but with a specified due date - no on-site use, not specifying a due date - Turn off SpecifyDueDate - on-site use with and without restriction should set the due date to the current date now
Created attachment 36689 [details] [review] Bug 13647: On-site checkouts - Allow library to specify due date This will remove the restriction that forces the due date for an on-site checkout to the end of the current day. It will still suggest the end of the day, but you will be able to change the date to whatever you want using the datepicker widget. To test: Before applying the patch: - Turn on OnSiteCheckouts and OnSiteCheckoutsForce system preferences - Check the on-site use checkbox and try to set due date manually, it should not be possible - Check out the item and check the due date is set to the end of today - Put a restriction on your patron account and repeat steps, the item checked out should again have a due date at the end of the day > There should be no way to be able to check out an item with a 'custom' due date Apply the patch: - Repeat steps from above, check out - on-site use without a restriction on your account - without changing the due date - with a due date picked with the datepicker - on-site use with a restriction on your account ... see above - no on-site use but with a specified due date - no on-site use, not specifying a due date - Turn off SpecifyDueDate - on-site use with and without restriction should set the due date automatically to the end of the date now, altering the due date should not be possible.
oops, bad reflex :)
Created attachment 36691 [details] [review] Bug 13647: On-site checkouts - Allow library to specify due date This will remove the restriction that forces the due date for an on-site checkout to the end of the current day. It will still suggest the end of the day, but you will be able to change the date to whatever you want using the datepicker widget. To test: Before applying the patch: - Turn on OnSiteCheckouts and OnSiteCheckoutsForce system preferences - Check the on-site use checkbox and try to set due date manually, it should not be possible - Check out the item and check the due date is set to the end of today - Put a restriction on your patron account and repeat steps, the item checked out should again have a due date at the end of the day > There should be no way to be able to check out an item with a 'custom' due date Apply the patch: - Repeat steps from above, check out - on-site use without a restriction on your account - without changing the due date - with a due date picked with the datepicker - on-site use with a restriction on your account ... see above - no on-site use but with a specified due date - no on-site use, not specifying a due date - Turn off SpecifyDueDate - on-site use with and without restriction should set the due date automatically to the end of the date now, altering the due date should not be possible. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Created attachment 36701 [details] [review] Bug 13647: On-site checkouts - Allow library to specify due date This will remove the restriction that forces the due date for an on-site checkout to the end of the current day. It will still suggest the end of the day, but you will be able to change the date to whatever you want using the datepicker widget. To test: Before applying the patch: - Turn on OnSiteCheckouts and OnSiteCheckoutsForce system preferences - Check the on-site use checkbox and try to set due date manually, it should not be possible - Check out the item and check the due date is set to the end of today - Put a restriction on your patron account and repeat steps, the item checked out should again have a due date at the end of the day > There should be no way to be able to check out an item with a 'custom' due date Apply the patch: - Repeat steps from above, check out - on-site use without a restriction on your account - without changing the due date - with a due date picked with the datepicker - on-site use with a restriction on your account ... see above - no on-site use but with a specified due date - no on-site use, not specifying a due date - Turn off SpecifyDueDate - on-site use with and without restriction should set the due date automatically to the end of the date now, altering the due date should not be possible. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Good catch Katrina!
Pushed to 3.18.x will be in 3.18.5