Bug 13733 - Give librarians the ability to add messages to an item
Summary: Give librarians the ability to add messages to an item
Status: RESOLVED DUPLICATE of bug 17297
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 12272 13563
Blocks:
  Show dependency treegraph
 
Reported: 2015-02-19 15:08 UTC by Kyle M Hall
Modified: 2016-09-13 17:03 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13733 - Give librarians the ability to add messages to an item (16.65 KB, patch)
2015-02-19 15:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13733 - Give librarians the ability to add messages to an item (18.68 KB, patch)
2015-02-19 15:18 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13733 - Give librarians the ability to add messages to an item (20.05 KB, patch)
2015-02-19 16:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13733 - Give librarians the ability to add messages to an item (20.05 KB, patch)
2015-03-02 16:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13733 - Give librarians the ability to add messages to an item (20.01 KB, patch)
2015-03-02 16:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13733 - Give librarians the ability to add messages to an item (20.06 KB, patch)
2015-03-19 15:35 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-02-19 15:08:01 UTC
Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list.
Comment 1 Kyle M Hall 2015-02-19 15:10:09 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2015-02-19 15:18:03 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2015-02-19 16:53:00 UTC Comment hidden (obsolete)
Comment 4 François Pichenot 2015-03-02 15:50:22 UTC
In item's detail, I can write a message of a type defined in an authorised value list, but I can't save it.

Second problem : the ability to add message doesn't appear in "edit items".
Comment 5 Kyle M Hall 2015-03-02 16:08:01 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2015-03-02 16:08:23 UTC
I believe the problem was in the database update. Please retest!
Comment 7 Kyle M Hall 2015-03-02 16:13:32 UTC Comment hidden (obsolete)
Comment 8 François Pichenot 2015-03-02 16:37:08 UTC
Ok, it works.

But I think it would be better if the message also appears in the "normal" view.
Comment 9 Pierre Angot 2015-03-03 11:45:52 UTC
I've tested on sandbox, but there is a software error when we click on items tab.

Software error:

Template process failed: file error - doc-head-angular.inc: not found at /home/koha/src/C4/Templates.pm line 121.

For help, please send mail to the webmaster (webmaster@test5-sandbox), giving this error message and the time and date of the error.


It seem to be linked to patch 13563.
Comment 10 Kyle M Hall 2015-03-03 14:30:39 UTC
(In reply to Pierre Angot from comment #9)
> I've tested on sandbox, but there is a software error when we click on items
> tab.
> 
> Software error:
> 
> Template process failed: file error - doc-head-angular.inc: not found at
> /home/koha/src/C4/Templates.pm line 121.
> 
> For help, please send mail to the webmaster (webmaster@test5-sandbox),
> giving this error message and the time and date of the error.
> 
> 
> It seem to be linked to patch 13563.

I believe that must be because you did not apply the two dependencies.
Comment 11 Pierre Angot 2015-03-03 14:47:41 UTC
Yes, you are right ! 

Sorry for the mistake.
Comment 12 Kyle M Hall 2015-03-19 15:35:00 UTC
Created attachment 37012 [details] [review]
Bug 13733 - Give librarians the ability to add messages to an item

Some librarians would like the ability to leave messages attached to an
item ( outside the scope of itemnotes and itemnotes_nonpublic ). This
feature would give the librarians the ability to add and remove messages
of arbitrary types defined in an authorised value list.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create some ITEM_MESSAGE authorised values
4) View an item's details
5) Try adding and deleting messages on an item

Signed-off-by: F Pichenot <fpichenot@ville-roubaix.fr>
Comment 13 Katrin Fischer 2015-04-22 22:41:29 UTC
This appears to be blocked by its dependencies on Angular and C4::Service currently.

I think we need to figure out if both of those are getting in, before we can continue here. I did a code review and spotted nothing obvious.
Comment 14 Kyle M Hall 2016-09-13 17:03:50 UTC

*** This bug has been marked as a duplicate of bug 17297 ***