Bug 13811 - Add verbose option borrowers-force-messaging-defaults
Summary: Add verbose option borrowers-force-messaging-defaults
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-09 19:16 UTC by Maxime Beaulieu
Modified: 2025-10-23 12:15 UTC (History)
9 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Added -s|--silent option to borrowers-force-messaging-defaults (2.22 KB, patch)
2015-03-09 19:19 UTC, Maxime Beaulieu
Details | Diff | Splinter Review
check-url's --html option prints directly to a file instead of stdout. (3.04 KB, patch)
2015-03-09 19:20 UTC, Maxime Beaulieu
Details | Diff | Splinter Review
Bug 13811: Add verbose option and logging to borrowers-force-messaging-defaults script (3.07 KB, patch)
2025-10-23 12:07 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 13811: MOve POD and script to top (5.72 KB, patch)
2025-10-23 12:07 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 13811: Use 'commit' but continue to support 'doit' (1.12 KB, patch)
2025-10-23 12:07 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Beaulieu 2015-03-09 19:16:26 UTC

    
Comment 1 Maxime Beaulieu 2015-03-09 19:19:19 UTC
Created attachment 36749 [details] [review]
Added -s|--silent option to borrowers-force-messaging-defaults

The script will not print to stdout when the flag is activated.

Test:
    Run the script with the flag. All to stdout is eliminated.
    Run the scirpt without the flag. A report is printed to stdout.

sponsored by: CCSR
Comment 2 Maxime Beaulieu 2015-03-09 19:20:18 UTC
Created attachment 36750 [details] [review]
check-url's --html option prints directly to a file instead of stdout.

This change makes the option behave more like other cronjob's --html or --csv options.
It also makes the script silent while printing html, as nothing is printed to stdout unless the verbose option is passed.

The script's behaviour is not changed when launched without options. (Prints in stdout)

sponsored by: CCSR
Comment 3 Marc Véron 2015-03-21 06:14:32 UTC
Status is NEW, but patches attached.
Comment 4 Frédéric Demians 2015-04-13 14:09:27 UTC
1) Could you document the new --silent parameter in the POD section of
   borrowers-force-messaging-defaults?

2) Why don't you modify check-url-quick.pl? check-url.pl is supposed to be
   deprecated.

3) As 1), the new way --html operates imposes to modify the documentation.

4) It may be better to have two bugs: one for each modified script.
Comment 5 Katrin Fischer 2023-07-28 21:55:06 UTC
I believe maybe instead of a --silent we should have a --verbose?
Comment 6 David Cook 2023-07-30 23:48:45 UTC
(In reply to Katrin Fischer from comment #5)
> I believe maybe instead of a --silent we should have a --verbose?

+1
Comment 7 Blou 2023-08-07 18:24:14 UTC
ooooh, a time machine!  :-)

Yes, fair point.  I had to dig to recover references to this Bug.  Unfortunately, our sponsor pulled the plug on this one a while ago.  Could be simple to do, but I can't prioritize this in any fashion.
Comment 8 Katrin Fischer 2023-08-07 18:48:15 UTC
(In reply to Blou from comment #7)
> ooooh, a time machine!  :-)
> 
> Yes, fair point.  I had to dig to recover references to this Bug. 
> Unfortunately, our sponsor pulled the plug on this one a while ago.  Could
> be simple to do, but I can't prioritize this in any fashion.

That's too bad, but thanks for the feedback :)
Comment 9 Nick Clemens (kidclamp) 2025-10-23 12:07:19 UTC
Created attachment 188344 [details] [review]
Bug 13811: Add verbose option and logging to borrowers-force-messaging-defaults script
Comment 10 Nick Clemens (kidclamp) 2025-10-23 12:07:22 UTC
Created attachment 188345 [details] [review]
Bug 13811: MOve POD and script to top
Comment 11 Nick Clemens (kidclamp) 2025-10-23 12:07:25 UTC
Created attachment 188346 [details] [review]
Bug 13811: Use 'commit' but continue to support 'doit'
Comment 12 Nick Clemens (kidclamp) 2025-10-23 12:15:17 UTC
I did what I could here, the html for check-url-quick needs a new bug