This bug is to track the backport of the HEA feature to Koha 3.16 and/or 3.14
Created attachment 37559 [details] [review] Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha
Once this patch is appears in a future Koha release, the HEA patchset can be added to older Kohas. Note: this patch is not essential for HEA to be backported, as the 'duplicated rows' SQL warnings without this patch are harmless and not fatal - but it would be nice to avoid those warnings, if possible
What's the discussion here? The patch does not apply on 3.14.x nor 3.16.x.
(In reply to Jonathan Druart from comment #3) > What's the discussion here? > The patch does not apply on 3.14.x nor 3.16.x. the patch is only to be applied for the master/3.18.x branches it's just to stop any 'duplicate rows' SQL upgrade warnings, when a 3.16/3.14 Koha upgrades to 3.18.x or higher make sense?
(In reply to Mason James from comment #4) > (In reply to Jonathan Druart from comment #3) > > What's the discussion here? > > The patch does not apply on 3.14.x nor 3.16.x. > > > the patch is only to be applied for the master/3.18.x branches > > it's just to stop any 'duplicate rows' SQL upgrade warnings, when a > 3.16/3.14 Koha upgrades to 3.18.x or higher > > make sense? Ha yes, sorry. It defenitely makes sense! So needs signoff :)
Test plan?
(In reply to M. Tompsett from comment #6) > Test plan? Test plan: 1/ Look at the patch 2/ You will know what you should test 3/ I you don't, test another patch
Created attachment 38003 [details] [review] Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Add the missing prefs unless they exist and don't raise an error if already exist.
I think that now we need the patch in master, 3.20 and 3.18?
Created attachment 39954 [details] [review] [PASSED QA] Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Add the missing prefs unless they exist and don't raise an error if already exist. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #9) > I think that now we need the patch in master, 3.20 and 3.18? yep, thats correct Katrin
(In reply to Katrin Fischer from comment #9) > I think that now we need the patch in master, 3.20 and 3.18? RMaints(In reply to Mason James from comment #11) > (In reply to Katrin Fischer from comment #9) > > I think that now we need the patch in master, 3.20 and 3.18? > > yep, thats correct Katrin Patch has passed QA, and is waiting to be pulled to master, 3.22, 3.20 and 3.18 branches
(In reply to Mason James from comment #12) > (In reply to Katrin Fischer from comment #9) > > I think that now we need the patch in master, 3.20 and 3.18? > > RMaints(In reply to Mason James from comment #11) > > (In reply to Katrin Fischer from comment #9) > > > I think that now we need the patch in master, 3.20 and 3.18? > > > > yep, thats correct Katrin > > > Patch has passed QA, and is waiting to be pulled to master, 3.22, 3.20 and > 3.18 branches hmm, actually... this patch can probably be WONTFIX, as its for 2 very old Koha versions :)