Bug 14110 - Silence warnings t/00-load.t
Summary: Silence warnings t/00-load.t
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: M. Tompsett
QA Contact: Galen Charlton
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 8879
  Show dependency treegraph
 
Reported: 2015-05-01 18:26 UTC by M. Tompsett
Modified: 2016-06-02 01:55 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 14110: Silence t/00-load.t warnings (2.08 KB, patch)
2015-05-01 18:36 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug 14110: Silence t/00-load.t warnings (2.21 KB, patch)
2015-05-15 21:20 UTC, Indranil Das Gupta
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description M. Tompsett 2015-05-01 18:26:46 UTC
Noted: bug 8879 is an omnibus for the ./t errors.

This cleanly catches all the errors in t/00-load.t, but it does not clean up the Koha tests which actually exclude testing Koha/NorwegianPatronDB.pm!
Comment 1 M. Tompsett 2015-05-01 18:36:46 UTC Comment hidden (obsolete)
Comment 2 Indranil Das Gupta 2015-05-15 21:20:50 UTC
Created attachment 39226 [details] [review]
Bug 14110: Silence t/00-load.t warnings

prove t/00-load.t has noisy messages. This catches them.

TEST PLAN
---------
1) $ prove -v t/00-load.t
   -- ugly INIT errors, etc.
2) apply patch
3) $ prove -v t/00-load.t
   -- nice "Expected warnings" type messages on
      the ones that were noisy.
4) koha qa test tools

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>

Test remarks: Expected outcome as per test plan. No anomaly noted.
Comment 3 Jonathan Druart 2015-05-22 09:38:50 UTC
These warnings should not be hidden, we should fix them correctly.
IMO this is not valid.
Comment 4 M. Tompsett 2015-05-27 21:07:20 UTC
(In reply to Jonathan Druart from comment #3)
> These warnings should not be hidden, we should fix them correctly.
> IMO this is not valid.

In which case, I would recommend three new bugs. I would recommend 4, but the hbbyy whatever it is barcode is deprecated. We should just catch that error, since there is no sense in fixing something declared deprecated.
Comment 5 Katrin Fischer 2015-05-31 12:33:36 UTC
> In which case, I would recommend three new bugs. I would recommend 4, but
> the hbbyy whatever it is barcode is deprecated. We should just catch that
> error, since there is no sense in fixing something declared deprecated.

Hm, why do you think it's deprecated? <branchcode>yymm0001 is still a valid choice for AutoBarcode.
Comment 6 M. Tompsett 2015-06-04 02:58:38 UTC
(In reply to Katrin Fischer from comment #5)
> > In which case, I would recommend three new bugs. I would recommend 4, but
> > the hbbyy whatever it is barcode is deprecated. We should just catch that
> > error, since there is no sense in fixing something declared deprecated.
> 
> Hm, why do you think it's deprecated? <branchcode>yymm0001 is still a valid
> choice for AutoBarcode.

perldoc C4/Barcodes/hbyymmincr.pm
Comment from 2008 by Joe Atzberger.
Comment 7 Katrin Fischer 2015-06-06 11:31:01 UTC
Hi Mark, I see... but I am not sure this is enough to deprecate as probably noone remembers it and no steps have been taken to remove the format from new installation or mark it as deprecated. 
I have my doubts about treating it as deprecated.
Comment 8 M. Tompsett 2016-06-02 01:55:42 UTC
I think this bug is best suited for the DBIx Mock related warnings, as the INIT warnings currently in t/00-load.t have been dealt with in bug 16635, bug 16636, and bug 16637.