When performing upgrades, the code should re-check for required dependencies. This is particularly important for those installations which are not package-based.
Created attachment 38874 [details] [review] Bug 14152: Re-check required dependencies during upgrade process This code causes the installer to re-check dependencies during the upgrade process. Test Plan: 1. Remove a required dependency. (Such as the recently added PDF::FromHTML and associated HTML::Tidy.) 2. Run the installer and note that it does not catch the missing dependency. 3. Also note that things break badly due to the missing dependency. 4. Apply this patch. 5. Under Global System Preferences > Local Use > Version change the dev revision number back one unit and save. 6. The updater will run and catch the missing dependency. 7. Install the missing dependency. 8. Return to the updater and continue with the update. 9. The update should complete successfully.
Created attachment 38877 [details] [review] Bug 14152: Re-check required dependencies during upgrade process This code causes the installer to re-check dependencies during the upgrade process. Test Plan --------- 1) Log in to staff client 2) Koha Administration -> Global system preferences -> Local 3) Change Version to previous version -- DO NOT HIT SAVE YET! 4) In command line: sudo apt-get purge libpdf-fromhtml-perl NOTE: This could be ANY required library. I chose PDF::FromHTML, because it has been a thorn in my side. 5) NOW! Hit the 'Save' button. 6) Log in, etc. etc... -- Blows up on redirect to log in. 7) In command line, add it back (I had to compile my own so, I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...) 8) Apply patch 9) Edit the C4/Installer/PerlDependencies.pm to make PDF::FromHTML required. See also bug 14103. 10) Log in to staff client 11) Koha Administration -> Global system preferences -> Local 12) Change Version to previous version -- DO NOT HIT SAVE YET! 13) In command line: sudo apt-get purge libpdf-fromhtml-perl 14) NOW! Hit the 'Save' button. 15) Log in, etc. etc... 16) Once warned you are missing it, add it back at the command line. 17) Click 'Recheck' -- Proceeds as expected now. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
With libxml-libxslt-perl, there is no kaboom, but somehow it let's you proceed. Once the patch is applied, it is properly caught. Don't let the test case I gave with PDF::FromHTML stop this from passing QA. :)
Thanks for taking cara of this, Chris.
(In reply to M. Tompsett from comment #3) > With libxml-libxslt-perl, there is no kaboom, -- the staff client, but OPAC will barf nicely when you try to search for something. > but somehow it lets you proceed. > Once the patch is applied, it is properly caught. YAY! Please Pass QA this. :)
Created attachment 38973 [details] [review] [PASSED QA] Bug 14152: Re-check required dependencies during upgrade process This code causes the installer to re-check dependencies during the upgrade process. Test Plan --------- 1) Log in to staff client 2) Koha Administration -> Global system preferences -> Local 3) Change Version to previous version -- DO NOT HIT SAVE YET! 4) In command line: sudo apt-get purge libpdf-fromhtml-perl NOTE: This could be ANY required library. I chose PDF::FromHTML, because it has been a thorn in my side. 5) NOW! Hit the 'Save' button. 6) Log in, etc. etc... -- Blows up on redirect to log in. 7) In command line, add it back (I had to compile my own so, I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...) 8) Apply patch 9) Edit the C4/Installer/PerlDependencies.pm to make PDF::FromHTML required. See also bug 14103. 10) Log in to staff client 11) Koha Administration -> Global system preferences -> Local 12) Change Version to previous version -- DO NOT HIT SAVE YET! 13) In command line: sudo apt-get purge libpdf-fromhtml-perl 14) NOW! Hit the 'Save' button. 15) Log in, etc. etc... 16) Once warned you are missing it, add it back at the command line. 17) Click 'Recheck' -- Proceeds as expected now. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Chris!